fix: change netty-nio-client Maven scope from runtime to compile#12
Merged
Conversation
The pom.xml declared netty-nio-client with <scope>runtime</scope>, which excludes it from the compile classpath. SageMakerTransportFactory imports NettyNioAsyncHttpClient and Http2Configuration from software.amazon.awssdk.http.nio.netty, causing the Maven build to fail with 'package does not exist' during the publish step. The Gradle build correctly uses implementation scope (compile-visible). Removing the runtime scope restores parity and allows mvn deploy to compile.
VWang1111
approved these changes
Apr 13, 2026
lukeocodes
added a commit
that referenced
this pull request
Apr 13, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2026-04-13) ### Bug Fixes * change netty-nio-client Maven scope from runtime to compile ([3faa74b](3faa74b)) * change netty-nio-client Maven scope from runtime to compile ([#12](#12)) ([df86a2d](df86a2d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netty-nio-clientwas declared<scope>runtime</scope>inpom.xml, which excludes it from the compile classpathSageMakerTransportFactoryimportsNettyNioAsyncHttpClientandHttp2Configurationfromsoftware.amazon.awssdk.http.nio.netty, causingmvn deployto fail at compile time with package does not exist — never reaching the publish step<scope>runtime</scope>tag, defaulting tocompilescope, matching the Gradleimplementationdeclaration insagemaker-transport/build.gradleRelated
Fixes the failing Maven Central publish in https://github.com/deepgram/deepgram-java-sdk-transport-sagemaker/actions/runs/24363491272/job/71149256941