Use nullish coalescing#136
Merged
Merged
Conversation
lukeocodes
approved these changes
Jun 7, 2023
lukeocodes
left a comment
lukeocodes
left a comment
Member
There was a problem hiding this comment.
I have a couple questions for Slack but it LGTM
for reference and posterity: https://mariusschulz.com/blog/nullish-coalescing-the-operator-in-typescript#providing-fallback-values-with-the-operator
Member
|
@briancbarrow could we tag this as a pre-release before it goes into main and try it on all of the current projects being built? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the Deepgram constructor to use
??instead of||. This change makes the SDK compatible with onprem for streaming (batch needs additional updates). TheapiUrlcould probably be left as||, butrequireSSLneeds to be the "nullish coalescing" operator??as otherwise if set to "False" for the onprem case the||operator will still default to the default option.