Remove useless asserts, and migrate an error closer to API

Author: niloc132

web/client-api/src/main/java/io/deephaven/web/client/api/JsRangeSet.java

@@ -24,6 +24,9 @@ public class JsRangeSet {
     private final RangeSet range;
 
     public static JsRangeSet ofRange(double first, double last) {
+        if (first > last) {
+            throw new IllegalStateException(first + " > " + last);
+        }
         return new JsRangeSet(RangeSet.ofRange((long) first, (long) last));
     }
 

web/shared-beans/src/main/java/io/deephaven/web/shared/data/Range.java

@@ -4,7 +4,6 @@
 package io.deephaven.web.shared.data;
 
 import javax.annotation.Nonnull;
-import java.io.Serializable;
 
 /**
  * Describes a contiguous range of at least one item. Equals/hashcode compare both start and end, but comparing Range
@@ -15,15 +14,7 @@ public class Range implements Comparable<Range> {
     private final long first;
     private final long last;
 
-    // serialization
-    Range() {
-        this(0, 0);
-    }
-
     public Range(long first, long last) {
-        if (first > last) {
-            throw new IllegalStateException(first + " > " + last);
-        }
         this.first = first;
         this.last = last;
     }
@@ -70,13 +61,10 @@ public Range[] minus(Range range) {
         // otherwise either the subtracted section's start is within our range _or_ its end is within our range,
         // and we can use that to only produce the one range we need to return
         if (range.first <= first) {
-            assert range.last >= first : "removed range expected to not end before existing range";
             return new Range[] {
                     new Range(range.last + 1, last)
             };
         } else {
-            assert range.last >= last : "removed range expected to end by the end of the existing range";
-            assert range.first <= last : "removed range expected to start before existing range";
             return new Range[] {
                     new Range(first, range.first - 1)
             };