fix: Version bump + loading spinner fixes (#243)

- DHC version bump
- Fixed infinite loading spinner
 
fixes #241

Author: bmingles

.gitignore

@@ -13,6 +13,7 @@ tsconfig.tsbuildinfo
 .tox/
 
 .eslintcache
+.jest-cache
 .stylelintcache
 
 # Ignore the test reports

package-lock.json

@@ -35,7 +35,7 @@
     "build": "tsc && vite build"
   },
   "devDependencies": {
-    "@deephaven/jsapi-types": "0.55.0",
+    "@deephaven/jsapi-types": "0.62.0",
     "@types/deep-equal": "^1.0.1",
     "@types/plotly.js": "^2.12.18",
     "@types/plotly.js-dist-min": "^2.3.1",
@@ -50,15 +50,15 @@
     "react": "^17.0.2"
   },
   "dependencies": {
-    "@deephaven/chart": "0.55.0",
-    "@deephaven/components": "0.55.0",
-    "@deephaven/dashboard": "0.55.0",
-    "@deephaven/dashboard-core-plugins": "0.55.0",
-    "@deephaven/icons": "0.55.0",
-    "@deephaven/jsapi-bootstrap": "0.55.0",
-    "@deephaven/log": "0.55.0",
-    "@deephaven/plugin": "0.55.0",
-    "@deephaven/utils": "0.55.0",
+    "@deephaven/chart": "0.62.0",
+    "@deephaven/components": "0.62.0",
+    "@deephaven/dashboard": "0.62.0",
+    "@deephaven/dashboard-core-plugins": "0.62.0",
+    "@deephaven/icons": "0.62.0",
+    "@deephaven/jsapi-bootstrap": "0.62.0",
+    "@deephaven/log": "0.62.0",
+    "@deephaven/plugin": "0.62.0",
+    "@deephaven/utils": "0.62.0",
     "deep-equal": "^2.2.1",
     "plotly.js": "^2.23.0",
     "plotly.js-dist-min": "^2.23.0",

plugins/plotly-express/src/js/package.json

@@ -1,13 +1,14 @@
 import React, { useEffect, useRef, useState } from 'react';
 import Plotly from 'plotly.js-dist-min';
 import { Chart } from '@deephaven/chart';
+import type { Widget } from '@deephaven/jsapi-types';
 import { type WidgetComponentProps } from '@deephaven/plugin';
 import { useApi } from '@deephaven/jsapi-bootstrap';
 import PlotlyExpressChartModel from './PlotlyExpressChartModel.js';
 import { useHandleSceneTicks } from './useHandleSceneTicks.js';
 
 export function PlotlyExpressChart(
-  props: WidgetComponentProps
+  props: WidgetComponentProps<Widget>
 ): JSX.Element | null {
   const dh = useApi();
   const { fetch } = props;

plugins/plotly-express/src/js/src/PlotlyExpressChart.tsx

@@ -101,6 +101,8 @@ export class PlotlyExpressChartModel extends ChartModel {
 
   hasPendingUpdate = false;
 
+  hasInitialLoadCompleted = false;
+
   override getData(): Partial<Data>[] {
     const hydratedData = [...this.plotlyData];
 
@@ -329,6 +331,15 @@ export class PlotlyExpressChartModel extends ChartModel {
   override fireUpdate(data: unknown): void {
     super.fireUpdate(data);
     this.hasPendingUpdate = false;
+
+    // TODO: This will fire on first call to `fireUpdate` even though other data
+    // may still be loading. We should consider making this smarter to fire after
+    // all initial data has loaded.
+    // https://github.com/deephaven/deephaven-plugins/issues/267
+    if (!this.hasInitialLoadCompleted) {
+      this.fireLoadFinished();
+      this.hasInitialLoadCompleted = true;
+    }
   }
 
   pauseUpdates(): void {

plugins/plotly-express/src/js/src/PlotlyExpressChartModel.ts

@@ -1,12 +1,13 @@
 import React, { useCallback, useRef, useState } from 'react';
 import Plotly from 'plotly.js-dist-min';
 import { ChartPanel, ChartPanelProps } from '@deephaven/dashboard-core-plugins';
+import type { Widget } from '@deephaven/jsapi-types';
 import { type WidgetPanelProps } from '@deephaven/plugin';
 import { useApi } from '@deephaven/jsapi-bootstrap';
 import PlotlyExpressChartModel from './PlotlyExpressChartModel.js';
 import { useHandleSceneTicks } from './useHandleSceneTicks.js';
 
-export function PlotlyExpressChartPanel(props: WidgetPanelProps) {
+export function PlotlyExpressChartPanel(props: WidgetPanelProps<Widget>) {
   const dh = useApi();
   const { fetch, metadata = {}, ...rest } = props;
   const containerRef = useRef<HTMLDivElement>(null);

plugins/plotly-express/src/js/src/PlotlyExpressChartPanel.tsx

@@ -1,9 +1,10 @@
 import { type WidgetPlugin, PluginType } from '@deephaven/plugin';
 import { vsGraph } from '@deephaven/icons';
+import type { Widget } from '@deephaven/jsapi-types';
 import { PlotlyExpressChart } from './PlotlyExpressChart.js';
 import { PlotlyExpressChartPanel } from './PlotlyExpressChartPanel.js';
 
-export const PlotlyExpressPlugin: WidgetPlugin = {
+export const PlotlyExpressPlugin: WidgetPlugin<Widget> = {
   name: '@deephaven/plotly-express',
   type: PluginType.WIDGET_PLUGIN,
   supportedTypes: 'deephaven.plot.express.DeephavenFigure',

plugins/plotly-express/src/js/src/PlotlyExpressPlugin.ts

@@ -3,6 +3,6 @@ isolated_build = True
 
 [testenv]
 deps =
-    deephaven-server>=0.29.0
+    deephaven-server==0.31.0
 commands =
     python -m unittest discover

plugins/plotly-express/tox.ini

@@ -55,13 +55,17 @@ beforeEach(() => {
 });
 
 it('should throw an error if no children to render', () => {
+  TestUtils.disableConsoleOutput();
+
   const children = makeDocument();
   expect(() => render(makeDocumentHandler({ children }))).toThrow(
     NoChildrenError
   );
 });
 
 it('should throw an error if the document mixes panel and non-panel elements', () => {
+  TestUtils.disableConsoleOutput();
+
   const children = makeDocument([
     makeElement(PANEL_ELEMENT_NAME),
     makeElement('not panel element'),