Skip to content

Commit db97c9a

Browse files
authored
refactor: Updated spectrum imports to use dh components (#424)
Imports for Spectrum components that are available in `@deephaven/components` have been updated. Components that are not yet re-exported by @deephaven/components: - `ButtonGroup`, `Checkbox` - we have our own implementations of these #433 We also will want to rename some things such that DH components aren't mapped to `SPECTRUM_ELEMENT_TYPE_PREFIX` #425 #366
1 parent c108f44 commit db97c9a

13 files changed

Lines changed: 415 additions & 394 deletions

package-lock.json

Lines changed: 361 additions & 341 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/ui/src/js/package.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,21 +42,21 @@
4242
},
4343
"dependencies": {
4444
"@adobe/react-spectrum": "^3.34.1",
45-
"@deephaven/chart": "^0.72.0",
46-
"@deephaven/components": "^0.72.0",
47-
"@deephaven/dashboard": "^0.72.0",
48-
"@deephaven/dashboard-core-plugins": "^0.72.0",
49-
"@deephaven/grid": "^0.72.0",
50-
"@deephaven/icons": "^0.72.0",
51-
"@deephaven/iris-grid": "^0.72.0",
52-
"@deephaven/jsapi-bootstrap": "^0.72.0",
53-
"@deephaven/jsapi-components": "^0.72.0",
45+
"@deephaven/chart": "^0.73.0",
46+
"@deephaven/components": "^0.73.0",
47+
"@deephaven/dashboard": "^0.73.0",
48+
"@deephaven/dashboard-core-plugins": "^0.73.0",
49+
"@deephaven/grid": "^0.73.0",
50+
"@deephaven/icons": "^0.73.0",
51+
"@deephaven/iris-grid": "^0.73.0",
52+
"@deephaven/jsapi-bootstrap": "^0.73.0",
53+
"@deephaven/jsapi-components": "^0.73.0",
5454
"@deephaven/jsapi-types": "^1.0.0-dev0.33.3",
55-
"@deephaven/log": "^0.72.0",
56-
"@deephaven/plugin": "^0.72.0",
57-
"@deephaven/react-hooks": "^0.72.0",
58-
"@deephaven/redux": "^0.72.0",
59-
"@deephaven/utils": "^0.72.0",
55+
"@deephaven/log": "^0.73.0",
56+
"@deephaven/plugin": "^0.73.0",
57+
"@deephaven/react-hooks": "^0.73.0",
58+
"@deephaven/redux": "^0.73.0",
59+
"@deephaven/utils": "^0.73.0",
6060
"@fortawesome/react-fontawesome": "^0.2.0",
6161
"@react-types/shared": "^3.22.0",
6262
"json-rpc-2.0": "^1.6.0",

plugins/ui/src/js/src/elements/ElementUtils.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { Text } from '@adobe/react-spectrum';
2+
import { Text } from '@deephaven/components';
33
import type { dh } from '@deephaven/jsapi-types';
44
import { TestUtils } from '@deephaven/utils';
55
import {

plugins/ui/src/js/src/elements/ElementUtils.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { Text } from '@adobe/react-spectrum';
2+
import { Text } from '@deephaven/components';
33
import type { dh } from '@deephaven/jsapi-types';
44
import { ITEM_ELEMENT_NAME } from './ElementConstants';
55
import ObjectView from './ObjectView';

plugins/ui/src/js/src/elements/SpectrumElementUtils.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
import { ButtonGroup, Checkbox } from '@adobe/react-spectrum';
2+
import { ValueOf } from '@deephaven/utils';
13
import {
2-
ButtonGroup,
3-
Checkbox,
44
Content,
55
ContextualHelp,
66
Grid,
@@ -14,9 +14,9 @@ import {
1414
TabList,
1515
Text,
1616
ToggleButton,
17-
} from '@adobe/react-spectrum';
18-
import { ValueOf } from '@deephaven/utils';
19-
import { Flex, View } from '@deephaven/components';
17+
Flex,
18+
View,
19+
} from '@deephaven/components';
2020
import {
2121
ActionButton,
2222
Button,
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import React from 'react';
22
import {
3-
ActionButton as SpectrumActionButton,
4-
SpectrumActionButtonProps,
5-
} from '@adobe/react-spectrum';
3+
ActionButton as DHCActionButton,
4+
ActionButtonProps as DHCActionButtonProps,
5+
} from '@deephaven/components';
66
import { SerializedButtonEventProps, useButtonProps } from './useButtonProps';
77

88
function ActionButton(
9-
props: SpectrumActionButtonProps & SerializedButtonEventProps
9+
props: DHCActionButtonProps & SerializedButtonEventProps
1010
): JSX.Element {
1111
const buttonProps = useButtonProps(props);
1212

1313
// eslint-disable-next-line react/jsx-props-no-spreading
14-
return <SpectrumActionButton {...buttonProps} />;
14+
return <DHCActionButton {...buttonProps} />;
1515
}
1616

1717
export default ActionButton;

plugins/ui/src/js/src/elements/spectrum/Form.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import React, { useCallback } from 'react';
2-
import { Form as SpectrumForm, SpectrumFormProps } from '@adobe/react-spectrum';
2+
import {
3+
Form as DHCForm,
4+
FormProps as DHCFormProps,
5+
} from '@deephaven/components';
36

47
function Form(
5-
props: SpectrumFormProps & {
8+
props: DHCFormProps & {
69
onSubmit?: (data: { [key: string]: FormDataEntryValue }) => void;
710
}
811
): JSX.Element {
@@ -22,7 +25,7 @@ function Form(
2225

2326
return (
2427
// eslint-disable-next-line react/jsx-props-no-spreading
25-
<SpectrumForm onSubmit={onSubmit} {...otherProps} />
28+
<DHCForm onSubmit={onSubmit} {...otherProps} />
2629
);
2730
}
2831

plugins/ui/src/js/src/elements/spectrum/RangeSlider.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import React, { useCallback, useState } from 'react';
22
import {
3-
RangeSlider as SpectrumRangeSlider,
4-
SpectrumRangeSliderProps,
5-
} from '@adobe/react-spectrum';
3+
RangeSlider as DHCRangeSlider,
4+
RangeSliderProps as DHCRangeSliderProps,
5+
} from '@deephaven/components';
66
import { useDebouncedCallback } from '@deephaven/react-hooks';
77

88
const VALUE_CHANGE_DEBOUNCE = 250;
99

1010
const EMPTY_FUNCTION = () => undefined;
1111

12-
function RangeSlider(props: SpectrumRangeSliderProps): JSX.Element {
12+
function RangeSlider(props: DHCRangeSliderProps): JSX.Element {
1313
const {
1414
defaultValue = { start: 0, end: 0 },
1515
value: propValue,
@@ -34,7 +34,7 @@ function RangeSlider(props: SpectrumRangeSliderProps): JSX.Element {
3434

3535
return (
3636
// eslint-disable-next-line react/jsx-props-no-spreading
37-
<SpectrumRangeSlider value={value} onChange={onChange} {...otherProps} />
37+
<DHCRangeSlider value={value} onChange={onChange} {...otherProps} />
3838
);
3939
}
4040

plugins/ui/src/js/src/elements/spectrum/Slider.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import React, { useCallback, useState } from 'react';
22
import {
3-
Slider as SpectrumSlider,
4-
SpectrumSliderProps,
5-
} from '@adobe/react-spectrum';
3+
Slider as DHCSlider,
4+
SliderProps as DHCSliderProps,
5+
} from '@deephaven/components';
66
import { useDebouncedCallback } from '@deephaven/react-hooks';
77

88
const VALUE_CHANGE_DEBOUNCE = 250;
99

1010
const EMPTY_FUNCTION = () => undefined;
1111

12-
function Slider(props: SpectrumSliderProps): JSX.Element {
12+
function Slider(props: DHCSliderProps): JSX.Element {
1313
const {
1414
defaultValue = 0,
1515
value: propValue,
@@ -34,7 +34,7 @@ function Slider(props: SpectrumSliderProps): JSX.Element {
3434

3535
return (
3636
// eslint-disable-next-line react/jsx-props-no-spreading
37-
<SpectrumSlider value={value} onChange={onChange} {...otherProps} />
37+
<DHCSlider value={value} onChange={onChange} {...otherProps} />
3838
);
3939
}
4040

plugins/ui/src/js/src/elements/spectrum/TabPanels.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,14 @@
11
import React from 'react';
22
import {
3-
TabPanels as SpectrumTabPanels,
4-
SpectrumTabPanelsProps,
5-
} from '@adobe/react-spectrum';
3+
TabPanels as DHCTabPanels,
4+
TabPanelsProps as DHCTabPanelsProps,
5+
} from '@deephaven/components';
66

7-
function TabPanels(
8-
props: SpectrumTabPanelsProps<React.ReactNode>
9-
): JSX.Element {
7+
function TabPanels(props: DHCTabPanelsProps<React.ReactNode>): JSX.Element {
108
const { UNSAFE_style: unsafeStyle, ...otherProps } = props;
119

1210
return (
13-
<SpectrumTabPanels
11+
<DHCTabPanels
1412
// eslint-disable-next-line react/jsx-props-no-spreading
1513
{...otherProps}
1614
UNSAFE_style={{ display: 'flex', ...unsafeStyle }}

0 commit comments

Comments
 (0)