fix: DH-21407: Dehydrate/hydrate pending data correctly (#2606)

- We were tryin to dehydrate the CellData object instead of the value
itself
- Just dehydrate the value itself
- Fix the tests
- This seems to have been broken for a long time, and only now it's
being caught when attempting to persist deephaven.ui data

Author: mofojed

packages/iris-grid/src/IrisGridUtils.test.ts

@@ -226,15 +226,15 @@ describe('pendingDataMap hydration/dehydration', () => {
         1,
         {
           data: new Map([
-            [3, 'Foo'],
-            [4, 'Bar'],
+            [3, { value: 'Foo' }],
+            [4, { value: 'Bar' }],
           ]),
         },
       ],
       [
         10,
         {
-          data: new Map([[7, 'Baz']]),
+          data: new Map([[7, { value: 'Baz' }]]),
         },
       ],
     ]);
@@ -267,10 +267,16 @@ describe('pendingDataMap hydration/dehydration', () => {
     );
     expect(hydratedMap.size).toBe(2);
     expect(hydratedMap.get(1)?.data.size).toBe(2);
-    expect(hydratedMap.get(1)?.data.get(3)).toEqual('Foo');
-    expect(hydratedMap.get(1)?.data.get(4)).toEqual('Bar');
+    expect(hydratedMap.get(1)?.data.get(3)).toEqual(
+      expect.objectContaining({ value: 'Foo' })
+    );
+    expect(hydratedMap.get(1)?.data.get(4)).toEqual(
+      expect.objectContaining({ value: 'Bar' })
+    );
     expect(hydratedMap.get(10)?.data.size).toBe(1);
-    expect(hydratedMap.get(10)?.data.get(7)).toEqual('Baz');
+    expect(hydratedMap.get(10)?.data.get(7)).toEqual(
+      expect.objectContaining({ value: 'Baz' })
+    );
   });
 });
 

packages/iris-grid/src/IrisGridUtils.ts

@@ -148,7 +148,7 @@ export interface DehydratedIrisGridState {
   selectDistinctColumns: readonly ColumnName[];
   selectedSearchColumns: readonly ColumnName[];
   invertSearchColumns: boolean;
-  pendingDataMap: DehydratedPendingDataMap<string | CellData | null>;
+  pendingDataMap: DehydratedPendingDataMap<unknown>;
   frozenColumns: readonly ColumnName[];
   columnHeaderGroups?: readonly DhType.ColumnGroup[];
   partitionConfig?: DehydratedPartitionConfig;
@@ -1495,36 +1495,28 @@ class IrisGridUtils {
 
   dehydratePendingDataMap(
     columns: readonly DhType.Column[],
-    pendingDataMap: ReadonlyMap<
-      ModelIndex,
-      {
-        data: Map<ModelIndex | ColumnName, CellData | string>;
-      }
-    >
-  ): DehydratedPendingDataMap<CellData | string | null> {
+    pendingDataMap: PendingDataMap
+  ): DehydratedPendingDataMap<unknown> {
     return [...pendingDataMap].map(([rowIndex, { data }]) => [
       rowIndex,
       {
         data: [...data]
           .filter(([c]) => typeof c === 'number')
-          .map(([c, value]) => [
+          .map(([c, cellData]) => [
             columns[c as number].name,
-            this.dehydrateValue(value, columns[c as number].type),
+            this.dehydrateValue(cellData.value, columns[c as number].type),
           ]),
       },
     ]);
   }
 
   hydratePendingDataMap(
     columns: readonly DhType.Column[],
-    pendingDataMap: DehydratedPendingDataMap<CellData | string | null>
+    pendingDataMap: DehydratedPendingDataMap<unknown>
   ): Map<
     number,
     {
-      data: Map<
-        ModelIndex | null,
-        string | CellData | DhType.LongWrapper | null
-      >;
+      data: Map<ModelIndex | null, CellData>;
     }
   > {
     const columnMap = new Map<ColumnName, number>();
@@ -1540,10 +1532,7 @@ class IrisGridUtils {
 
     return new Map(
       pendingDataMap.map(
-        ([rowIndex, { data }]: [
-          number,
-          { data: [string, CellData | string | null][] },
-        ]) => [
+        ([rowIndex, { data }]: [number, { data: [string, unknown][] }]) => [
           rowIndex,
           {
             data: new Map(
@@ -1552,7 +1541,7 @@ class IrisGridUtils {
                 assertNotNull(index);
                 return [
                   getColumnIndex(columnName) ?? null,
-                  this.hydrateValue(value, columns[index].type),
+                  { value: this.hydrateValue(value, columns[index].type) },
                 ];
               })
             ),