feat: Update @vscode/codicons to v0.0.33 (#1259)

Update adds several new icons see
https://github.com/microsoft/vscode-codicons/releases/tag/0.0.33 for
changes.

They renamed circle-large-outline to circle-large for naming
consistency. I've fixed our usage of vsCircleLargeOutline to
vsCircleLarge for the renamed icon (no change in visuals).

BREAKING CHANGE: `vsCircleLargeOutline` icon renamed to `vsCircleLarge`

Author: dsmmcken

package-lock.json

@@ -101,7 +101,7 @@
     "@types/react-window": "^1.8.5",
     "@types/shell-quote": "^1.7.1",
     "@types/shortid": "0.0.29",
-    "@vscode/codicons": "0.0.32",
+    "@vscode/codicons": "0.0.33",
     "chokidar-cli": "^2.1.0",
     "cross-env": "^7.0.2",
     "eslint": "^8.29.0",

package.json

@@ -1,7 +1,7 @@
 import React from 'react';
 import classNames from 'classnames';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
-import { vsCircleLargeOutline, vsLoading } from '@deephaven/icons';
+import { vsCircleLarge, vsLoading } from '@deephaven/icons';
 import './LoadingSpinner.scss';
 
 type LoadingSpinnerProps = {
@@ -18,7 +18,7 @@ function LoadingSpinner({
       className={classNames('loading-spinner fa-layers', className)}
       data-testid={dataTestId}
     >
-      <FontAwesomeIcon icon={vsCircleLargeOutline} className="text-white-50" />
+      <FontAwesomeIcon icon={vsCircleLarge} className="text-white-50" />
       <FontAwesomeIcon icon={vsLoading} className="text-primary" spin />
     </div>
   );

packages/components/src/LoadingSpinner.tsx

@@ -37,8 +37,8 @@ exports[`renders a menu from a promise returned from a function 1`] = `
         >
           <svg
             aria-hidden="true"
-            className="svg-inline--fa fa-circle-large-outline text-white-50"
-            data-icon="circle-large-outline"
+            className="svg-inline--fa fa-circle-large text-white-50"
+            data-icon="circle-large"
             data-prefix="vs"
             focusable="false"
             role="img"
@@ -206,8 +206,8 @@ exports[`renders an empty menu for a rejected promise 1`] = `
         >
           <svg
             aria-hidden="true"
-            className="svg-inline--fa fa-circle-large-outline text-white-50"
-            data-icon="circle-large-outline"
+            className="svg-inline--fa fa-circle-large text-white-50"
+            data-icon="circle-large"
             data-prefix="vs"
             focusable="false"
             role="img"

packages/components/src/context-actions/__snapshots__/ContextActions.test.tsx.snap

@@ -102,7 +102,7 @@ function callErrorFunction() {
 
 function expectLoading(container) {
   expect(
-    container.querySelector("[data-icon='circle-large-outline']")
+    container.querySelector("[data-icon='circle-large']")
   ).toBeInTheDocument();
   expect(container.querySelector("[data-icon='loading']")).toBeInTheDocument();
 }

packages/dashboard-core-plugins/src/panels/ChartPanel.test.tsx

@@ -81,7 +81,7 @@ function makeIrisGridPanelWrapper(
 async function expectLoading(container) {
   await waitFor(() =>
     expect(
-      container.querySelector("[data-icon='circle-large-outline']")
+      container.querySelector("[data-icon='circle-large']")
     ).toBeInTheDocument()
   );
   expect(container.querySelector("[data-icon='loading']")).toBeInTheDocument();