Skip to content

Commit 235c3a2

Browse files
authored
build: TypeScript fixes (#1392)
- JS to TS conversion fixes found from doing Enterprise conversion
1 parent b66c0de commit 235c3a2

3 files changed

Lines changed: 15 additions & 15 deletions

File tree

packages/components/src/context-actions/ContextActions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class ContextActions extends Component<
6161
* Items within groups are ordered by their order property, then by their title.
6262
*/
6363
static groups = {
64-
default: null,
64+
default: undefined,
6565
high: 100,
6666
medium: 5000,
6767
low: 10000,

packages/storage/src/Storage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export type FilterValue = number | string;
1+
export type FilterValue = number | string | string[];
22

33
export type FilterConfigItem = {
44
columnName: string;

packages/storage/src/StorageTableViewportUpdater.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ import {
1111
ViewportUpdateCallback,
1212
} from './Storage';
1313

14-
export type StorageTableViewportUpdaterProps = {
15-
table: StorageTable<StorageItem>;
14+
export type StorageTableViewportUpdaterProps<T extends StorageItem> = {
15+
table: StorageTable<T>;
1616
columns?: string[];
1717
top?: number;
1818
bottom?: number;
1919
filters?: FilterConfig[];
2020
sorts?: SortConfig[];
2121
isReversed?: boolean;
22-
onUpdate: ViewportUpdateCallback<StorageItem>;
22+
onUpdate: ViewportUpdateCallback<T>;
2323
};
2424

2525
const UPDATE_DELAY = 150;
@@ -28,7 +28,9 @@ const ROW_BUFFER_PAGES = 3;
2828

2929
const log = Log.module('StorageTableViewportUpdater');
3030

31-
export function StorageTableViewportUpdater({
31+
export function StorageTableViewportUpdater<
32+
T extends StorageItem = StorageItem
33+
>({
3234
table,
3335
columns,
3436
top = 0,
@@ -37,7 +39,7 @@ export function StorageTableViewportUpdater({
3739
sorts,
3840
isReversed = false,
3941
onUpdate,
40-
}: StorageTableViewportUpdaterProps): null {
42+
}: StorageTableViewportUpdaterProps<T>): null {
4143
const throttledUpdateViewport = useMemo(
4244
() =>
4345
throttle((viewport: StorageTableViewport) => {
@@ -59,14 +61,12 @@ export function StorageTableViewportUpdater({
5961

6062
useEffect(
6163
function updateViewportAndReturnCleanup() {
62-
const cleanup = table.onUpdate(
63-
(viewportData: ViewportData<StorageItem>) => {
64-
onUpdate({
65-
items: viewportData.items ?? [],
66-
offset: viewportData.offset ?? 0,
67-
});
68-
}
69-
);
64+
const cleanup = table.onUpdate((viewportData: ViewportData<T>) => {
65+
onUpdate({
66+
items: viewportData.items ?? [],
67+
offset: viewportData.offset ?? 0,
68+
});
69+
});
7070

7171
return () => {
7272
log.debug('onUpdate cleanup');

0 commit comments

Comments
 (0)