refactor: Fix fast refresh invalidations (#1150)

Fixes #727 as best we can w/o requiring major changes. HMR works best w/
functional components and that's too big of a change to switch
everything to functional components just for HMR.

Added an eslint rule which will warn about things that will almost
certainly invalidate HMR. Fixed the warnings it emitted.

Tested locally by changing some displayed text values in some panels and
seeing if the page triggered a full reload. I didn't have any specific
files/cases that triggered full reloads previously and it seems Vite 4
has made it better on its own. If we start running into cases.

Saving `GridRenderer` doesn't trigger a full page reload (didn't before
either), but massively slows the page (also had this behavior prior to
this change). The change eventually propagates and refreshes

We should keep an eye on vitejs/vite#12062
which will likely also fix the slow HMR issues on some components. There
seems to be duplication of modules in the update list and it can explode
at times (like GridRenderer triggers 14 unique modules, but 20k updates
consisting of just those 14)

BREAKING CHANGE:
Renamed `renderFileListItem` to `FileListItem`.
Renamed `RenderFileListItemProps` to `FileListItemProps`.
Removed exports for `ConsolePlugin.assertIsConsolePluginProps`,
`GridPlugin.SUPPORTED_TYPES`, `FileList.getPathFromItem`,
`FileList.DRAG_HOVER_TIMEOUT`, `FileList.getItemIcon`,
`Grid.directionForKey`, `GotoRow.isIrisGridProxyModel`, and
`Aggregations.SELECTABLE_OPTIONS`. These were all only being consumed
within their own file and are not consumed in enterprise

Author: mattrunyon

package-lock.json

@@ -8,6 +8,7 @@ import logInit from './log/LogInit';
 
 logInit();
 
+// eslint-disable-next-line react-refresh/only-export-components
 const AppRoot = React.lazy(() => import('./AppRoot'));
 
 ReactDOM.render(

packages/code-studio/src/index.tsx

@@ -377,7 +377,7 @@ const mapStateToProps = (state: RootState) => ({
   workspaceStorage: getWorkspaceStorage(state),
 });
 
-export default connect(mapStateToProps, {
+const ConnectedAppInit = connect(mapStateToProps, {
   setActiveTool: setActiveToolAction,
   setCommandHistoryStorage: setCommandHistoryStorageAction,
   setDashboardData: setDashboardDataAction,
@@ -391,3 +391,5 @@ export default connect(mapStateToProps, {
   setWorkspaceStorage: setWorkspaceStorageAction,
   setServerConfigValues: setServerConfigValuesAction,
 })(AppInit);
+
+export default ConnectedAppInit;

packages/code-studio/src/main/AppInit.tsx

@@ -904,8 +904,10 @@ const mapStateToProps = (state: RootState) => ({
   serverConfigValues: getServerConfigValues(state),
 });
 
-export default connect(mapStateToProps, {
+const ConnectedAppMainContainer = connect(mapStateToProps, {
   setActiveTool: setActiveToolAction,
   updateDashboardData: updateDashboardDataAction,
   updateWorkspaceData: updateWorkspaceDataAction,
 })(withRouter(AppMainContainer));
+
+export default ConnectedAppMainContainer;

packages/code-studio/src/main/AppMainContainer.tsx

@@ -644,6 +644,8 @@ const mapStateToProps = (state: RootState) => ({
   settings: getSettings(state),
 });
 
-export default connect(mapStateToProps, { saveSettings: saveSettingsAction })(
-  ColumnSpecificSectionContent
-);
+const ConnectedColumnSpecificSectionContent = connect(mapStateToProps, {
+  saveSettings: saveSettingsAction,
+})(ColumnSpecificSectionContent);
+
+export default ConnectedColumnSpecificSectionContent;

packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx

@@ -631,6 +631,8 @@ const mapStateToProps = (state: RootState) => ({
   settings: getSettings(state),
 });
 
-export default connect(mapStateToProps, { saveSettings: saveSettingsAction })(
-  FormattingSectionContent
-);
+const ConnectedFormattingSectionContent = connect(mapStateToProps, {
+  saveSettings: saveSettingsAction,
+})(FormattingSectionContent);
+
+export default ConnectedFormattingSectionContent;

packages/code-studio/src/settings/FormattingSectionContent.tsx

@@ -143,7 +143,9 @@ const mapStateToProps = (state: RootState) => ({
 
 const mapDispatchToProps = { saveSettings: saveSettingsAction };
 
-export default connect(
+const ConnectedShortcutSectionContent = connect(
   mapStateToProps,
   mapDispatchToProps
 )(ShortcutSectionContent);
+
+export default ConnectedShortcutSectionContent;

packages/code-studio/src/settings/ShortcutsSectionContent.tsx

@@ -44,6 +44,8 @@ const mapStateToProps = (state: RootState) => ({
   workspace: getWorkspace(state),
 });
 
-export default connect(mapStateToProps, {
+const ConnectedStyleGuideInit = connect(mapStateToProps, {
   setWorkspace: setWorkspaceAction,
 })(StyleGuideInit);
+
+export default ConnectedStyleGuideInit;

packages/code-studio/src/styleguide/StyleGuideInit.tsx

@@ -8,6 +8,7 @@ import logInit from '../log/LogInit';
 
 logInit();
 
+// eslint-disable-next-line react-refresh/only-export-components
 const StyleGuideRoot = React.lazy(() => import('./StyleGuideRoot'));
 
 ReactDOM.render(

packages/code-studio/src/styleguide/index.tsx

@@ -1,7 +1,8 @@
 import React from 'react';
 import { render, screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
-import DateTimeInput, { addSeparators } from './DateTimeInput';
+import DateTimeInput from './DateTimeInput';
+import { addSeparators } from './DateTimeInputUtils';
 
 const DEFAULT_DATE_TIME = '2022-02-22 00:00:00.000000000';
 // Zero width space