refactor: Added consistent-type-imports eslint rule and ran --fix (#2230)

- Added `@typescript-eslint/consistent-type-imports` linting rule
- Added package script `lint:packages`
- Ran `npm run lint:packages -- --fix`

> Note: despite the crazy large number of files, most of these were
changed automatically by eslint --fix, so should be able to skim
provided all automated tests pass.

resolves #2229

BREAKING CHANGE: eslint rule will require type only imports where
possible

Author: bmingles

package.json

@@ -31,6 +31,7 @@
     "build:profile": "lerna run build --stream --profile",
     "build:necessary": "lerna run build --scope=@deephaven/icons",
     "analyze": "lerna run analyze",
+    "lint:packages": "eslint \"packages/*/src/**/*.{ts,tsx,js,jsx}\"",
     "preview": "lerna run --scope=@deephaven/{code-studio,embed-widget} preview --stream",
     "preview:app": "lerna run --scope=@deephaven/code-studio preview --stream",
     "prestart": "npm run build:necessary",

packages/app-utils/src/components/AppBootstrap.test.tsx

@@ -2,7 +2,7 @@ import React, { useContext } from 'react';
 import { act, render, screen } from '@testing-library/react';
 import { AUTH_HANDLER_TYPE_ANONYMOUS } from '@deephaven/auth-plugins';
 import { ApiContext } from '@deephaven/jsapi-bootstrap';
-import { PluginModuleMap, PluginsContext } from '@deephaven/plugin';
+import { type PluginModuleMap, PluginsContext } from '@deephaven/plugin';
 import { BROADCAST_LOGIN_MESSAGE } from '@deephaven/jsapi-utils';
 import type {
   CoreClient,

packages/app-utils/src/components/AppDashboards.tsx

@@ -2,14 +2,15 @@ import React, { useCallback } from 'react';
 import classNames from 'classnames';
 import {
   DashboardUtils,
-  DehydratedDashboardPanelProps,
+  type DehydratedDashboardPanelProps,
   LazyDashboard,
 } from '@deephaven/dashboard';
 import { useObjectFetcher } from '@deephaven/jsapi-bootstrap';
-import LayoutManager, {
-  ItemConfig,
-  Settings as LayoutSettings,
+import {
+  type ItemConfig,
+  type Settings as LayoutSettings,
 } from '@deephaven/golden-layout';
+import type LayoutManager from '@deephaven/golden-layout';
 import { LoadingOverlay } from '@deephaven/components';
 
 interface AppDashboardsProps {

packages/app-utils/src/components/AuthBootstrap.tsx

@@ -1,6 +1,6 @@
 import React, { useContext, useEffect, useMemo, useState } from 'react';
 import {
-  AuthConfigMap,
+  type AuthConfigMap,
   AuthPluginAnonymous,
   AuthPluginParent,
   AuthPluginPsk,

packages/app-utils/src/components/ConnectionBootstrap.tsx

@@ -8,7 +8,7 @@ import {
 } from '@deephaven/components';
 import {
   ObjectFetcherContext,
-  ObjectFetchManager,
+  type ObjectFetchManager,
   ObjectFetchManagerContext,
   sanitizeVariableDescriptor,
   useApi,

packages/app-utils/src/plugins/PluginUtils.test.ts

@@ -1,4 +1,4 @@
-import { LegacyPlugin, Plugin, PluginType } from '@deephaven/plugin';
+import { type LegacyPlugin, type Plugin, PluginType } from '@deephaven/plugin';
 import { getPluginModuleValue } from './PluginUtils';
 
 describe('getPluginModuleValue', () => {

packages/app-utils/src/plugins/PluginUtils.tsx

@@ -4,13 +4,13 @@ import {
   type AuthPlugin,
   type AuthPluginComponent,
   isAuthPlugin,
-  LegacyAuthPlugin,
-  LegacyPlugin,
-  Plugin,
+  type LegacyAuthPlugin,
+  type LegacyPlugin,
+  type Plugin,
   PluginType,
   isLegacyAuthPlugin,
   isLegacyPlugin,
-  PluginModule,
+  type PluginModule,
   isPlugin,
 } from '@deephaven/plugin';
 import loadRemoteModule from './loadRemoteModule';

packages/app-utils/src/storage/LayoutStorage.ts

@@ -1,6 +1,6 @@
 import type { ItemConfig } from '@deephaven/golden-layout';
-import { FilterSet, Link } from '@deephaven/dashboard-core-plugins';
-import { PluginDataMap } from '@deephaven/redux';
+import { type FilterSet, type Link } from '@deephaven/dashboard-core-plugins';
+import { type PluginDataMap } from '@deephaven/redux';
 
 /**
  * Have a different version to support legacy layout exports

packages/app-utils/src/storage/LocalWorkspaceStorage.ts

@@ -1,19 +1,19 @@
 import Log from '@deephaven/log';
 import {
-  WorkspaceStorage,
-  WorkspaceStorageLoadOptions,
-  CustomizableWorkspaceData,
-  CustomizableWorkspace,
-  WorkspaceSettings,
-  ServerConfigValues,
+  type WorkspaceStorage,
+  type WorkspaceStorageLoadOptions,
+  type CustomizableWorkspaceData,
+  type CustomizableWorkspace,
+  type WorkspaceSettings,
+  type ServerConfigValues,
 } from '@deephaven/redux';
 import {
   DateTimeColumnFormatter,
   DecimalColumnFormatter,
   IntegerColumnFormatter,
 } from '@deephaven/jsapi-utils';
 import UserLayoutUtils from './UserLayoutUtils';
-import LayoutStorage from './LayoutStorage';
+import type LayoutStorage from './LayoutStorage';
 
 const log = Log.module('LocalWorkspaceStorage');
 

packages/app-utils/src/storage/UserLayoutUtils.test.ts

@@ -1,10 +1,11 @@
-import { FilterSet, Link } from '@deephaven/dashboard-core-plugins';
+import { type FilterSet, type Link } from '@deephaven/dashboard-core-plugins';
 import type { ItemConfig } from '@deephaven/golden-layout';
-import LayoutStorage, {
-  ExportedLayout,
-  ExportedLayoutV1,
-  ExportedLayoutV2,
+import {
+  type ExportedLayout,
+  type ExportedLayoutV1,
+  type ExportedLayoutV2,
 } from './LayoutStorage';
+import type LayoutStorage from './LayoutStorage';
 import UserLayoutUtils, {
   DEFAULT_LAYOUT_CONFIG,
   DEFAULT_LAYOUT_CONFIG_NO_CONSOLE,