Skip to content

Commit 3236c9b

Browse files
authored
fix: Improve the look of the error view (#2001)
- Add a little blur to overlays, so they're easier to read when on top of complex backgrounds - Change the colour and transparency level of the error background
1 parent 3de52d6 commit 3236c9b

5 files changed

Lines changed: 10 additions & 4 deletions

File tree

packages/components/scss/new_variables.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ $ant-thickness: 1px;
5454
$focus-bg-transparency: 12%;
5555
$hover-bg-transparency: 14%;
5656
$active-bg-transparency: 28%;
57-
$exception-transparency: 13%;
57+
$exception-transparency: 28%;

packages/components/scss/util.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@
7171
@return color-mix-opacity('negative', $i);
7272
}
7373

74+
@function negative-down-bg-opacity($i: 100) {
75+
@return color-mix-opacity('negative-down-bg', $i);
76+
}
77+
7478
@function black-opacity($i: 100) {
7579
@return color-mix-opacity('black', $i);
7680
}

packages/components/src/ErrorView.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
position: relative;
55
color: $danger;
66
border-radius: $border-radius;
7-
background-color: negative-opacity($exception-transparency);
7+
background-color: negative-down-bg-opacity($exception-transparency);
88
display: flex;
99
flex-direction: column;
1010
flex-grow: 0;

packages/components/src/LoadingOverlay.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
$iris-panel-message-font-size: 1.2rem;
44
$iris-panel-icon-font-size: 64px;
5-
$iris-panel-scrim-bg: black-opacity(10);
5+
$iris-panel-scrim-bg: bg-opacity(80);
66

77
.iris-panel-message-overlay {
88
text-align: center;
@@ -30,4 +30,5 @@ $iris-panel-scrim-bg: black-opacity(10);
3030

3131
.iris-panel-scrim-background {
3232
background: $iris-panel-scrim-bg;
33+
backdrop-filter: blur(2px);
3334
}

packages/dashboard-core-plugins/src/panels/ChartPanel.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
$chart-panel-disconnected-opacity: 0.18;
44
$overlay-message-font-size: 1.2rem;
5-
$overlay-scrim-bg: black-opacity(50);
5+
$overlay-scrim-bg: bg-opacity(80);
66
$overlay-content-max-width: 450px;
77

88
.iris-chart-panel {
@@ -24,6 +24,7 @@ $overlay-content-max-width: 450px;
2424

2525
.chart-panel-overlay {
2626
background-color: $overlay-scrim-bg;
27+
backdrop-filter: blur(1px);
2728
position: absolute;
2829
top: 0;
2930
bottom: 0;

0 commit comments

Comments
 (0)