Skip to content

Commit 372442d

Browse files
committed
Added catch for promise (#1858)
1 parent ac8b71e commit 372442d

1 file changed

Lines changed: 14 additions & 7 deletions

File tree

  • packages/jsapi-components/src/spectrum/Picker

packages/jsapi-components/src/spectrum/Picker/Picker.tsx

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,16 @@ import {
66
import { useApi } from '@deephaven/jsapi-bootstrap';
77
import { dh as DhType } from '@deephaven/jsapi-types';
88
import { Formatter } from '@deephaven/jsapi-utils';
9+
import Log from '@deephaven/log';
910
import { PICKER_ITEM_HEIGHT, PICKER_TOP_OFFSET } from '@deephaven/utils';
1011
import { useCallback, useEffect, useMemo } from 'react';
1112
import useGetItemIndexByValue from '../../useGetItemIndexByValue';
1213
import { useViewportData } from '../../useViewportData';
1314
import { getPickerKeyColumn } from './PickerUtils';
1415
import { usePickerItemRowDeserializer } from './usePickerItemRowDeserializer';
1516

17+
const log = Log.module('Picker');
18+
1619
export interface PickerProps extends Omit<PickerPropsBase, 'children'> {
1720
table: DhType.Table;
1821
/* The column of values to use as item keys. Defaults to the first column. */
@@ -81,13 +84,17 @@ export function Picker({
8184
function setViewportFromSelectedKey() {
8285
let isCanceled = false;
8386

84-
getItemIndexByValue().then(index => {
85-
if (index == null || isCanceled) {
86-
return;
87-
}
88-
89-
setViewport(index);
90-
});
87+
getItemIndexByValue()
88+
.then(index => {
89+
if (index == null || isCanceled) {
90+
return;
91+
}
92+
93+
setViewport(index);
94+
})
95+
.catch(err => {
96+
log.error('Error setting viewport from selected key', err);
97+
});
9198

9299
return () => {
93100
isCanceled = true;

0 commit comments

Comments
 (0)