Refactor PanelManager to use new listeners

Author: gzh2003

packages/dashboard/src/NavigationEvent.ts

@@ -1,6 +1,6 @@
 import { makeEventFunctions } from '@deephaven/golden-layout';
 
-export const NavigationEvent = Object.freeze({
+const NavigationEvent = Object.freeze({
   CYCLE_TO_NEXT_STACK: 'NavigationEvent.CYCLE_TO_NEXT_STACK',
   CYCLE_TO_PREVIOUS_STACK: 'NavigationEvent.CYCLE_TO_PREVIOUS_STACK',
   CYCLE_TO_NEXT_TAB: 'NavigationEvent.CYCLE_TO_NEXT_TAB',

packages/dashboard/src/PanelManager.ts

@@ -123,6 +123,10 @@ class PanelManager {
     eventHub.on(PanelEvent.MOUNT, this.handleMount);
     eventHub.on(PanelEvent.UNMOUNT, this.handleUnmount);
     eventHub.on(PanelEvent.REOPEN, this.handleReopen);
+    eventHub.on(PanelEvent.REOPEN_LAST, this.handleReopenLast);
+    eventHub.on(PanelEvent.DELETE, this.handleDeleted);
+    eventHub.on(PanelEvent.CLOSED, this.handleClosed);
+    eventHub.on(PanelEvent.CLOSE, this.handleControlClose);
     eventHub.on(
       NavigationEvent.CYCLE_TO_NEXT_STACK,
       this.handleCycleToNextStack
@@ -136,10 +140,6 @@ class PanelManager {
       NavigationEvent.CYCLE_TO_PREVIOUS_TAB,
       this.handleCycleToPreviousTab
     );
-    eventHub.on(PanelEvent.REOPEN_LAST, this.handleReopenLast);
-    eventHub.on(PanelEvent.DELETE, this.handleDeleted);
-    eventHub.on(PanelEvent.CLOSED, this.handleClosed);
-    eventHub.on(PanelEvent.CLOSE, this.handleControlClose);
     // PanelEvent.OPEN should be listened to by plugins to open a panel
   }
 
@@ -149,6 +149,10 @@ class PanelManager {
     eventHub.off(PanelEvent.MOUNT, this.handleMount);
     eventHub.off(PanelEvent.UNMOUNT, this.handleUnmount);
     eventHub.off(PanelEvent.REOPEN, this.handleReopen);
+    eventHub.off(PanelEvent.REOPEN_LAST, this.handleReopenLast);
+    eventHub.off(PanelEvent.DELETE, this.handleDeleted);
+    eventHub.off(PanelEvent.CLOSED, this.handleClosed);
+    eventHub.off(PanelEvent.CLOSE, this.handleControlClose);
     eventHub.off(
       NavigationEvent.CYCLE_TO_NEXT_STACK,
       this.handleCycleToNextStack
@@ -162,10 +166,6 @@ class PanelManager {
       NavigationEvent.CYCLE_TO_PREVIOUS_TAB,
       this.handleCycleToPreviousTab
     );
-    eventHub.off(PanelEvent.REOPEN_LAST, this.handleReopenLast);
-    eventHub.off(PanelEvent.DELETE, this.handleDeleted);
-    eventHub.off(PanelEvent.CLOSED, this.handleClosed);
-    eventHub.off(PanelEvent.CLOSE, this.handleControlClose);
   }
 
   getClosedPanelConfigsOfType(typeString: string): ClosedPanels {