Skip to content

Commit 448f0f0

Browse files
authored
feat: exposes editor-line-number-active-fg theme variable (#1833)
Fixes issue with active line number looking bad in light theme. - Exposes editor-line-number-active-fg as editor semanatic variable - Sets to blue/black in light theme to match vs code light theme approach
1 parent 25d1c09 commit 448f0f0

7 files changed

Lines changed: 9 additions & 2 deletions

File tree

packages/components/src/theme/theme-dark/theme-dark-semantic-editor.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
--dh-color-editor-bg: var(--dh-color-content-bg);
44
--dh-color-editor-fg: var(--dh-color-gray-900);
55
--dh-color-editor-error-fg: var(--dh-color-visual-red);
6-
--dh-color-editor-line-number-fg: var(--dh-color-gray-700);
6+
--dh-color-editor-line-number-fg: var(--dh-color-gray-600);
7+
--dh-color-editor-line-number-active-fg: var(--dh-color-gray-800);
78
--dh-color-editor-line-highlight-bg: var(--dh-color-gray-200);
89
--dh-color-editor-selection-bg: var(--dh-color-text-highlight);
910
--dh-color-editor-inactive-selection-bg: var(--dh-color-gray-300);

packages/components/src/theme/theme-light/theme-light-semantic-editor.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
--dh-color-editor-bg: var(--dh-color-content-bg);
44
--dh-color-editor-fg: var(--dh-color-gray-900);
55
--dh-color-editor-error-fg: var(--dh-color-visual-red);
6-
--dh-color-editor-line-number-fg: var(--dh-color-gray-700);
6+
--dh-color-editor-line-number-fg: var(--dh-color-cyan-1000);
7+
--dh-color-editor-line-number-active-fg: var(--dh-color-gray-900);
78
--dh-color-editor-line-highlight-bg: var(--dh-color-gray-100);
89
--dh-color-editor-selection-bg: var(--dh-color-text-highlight);
910
--dh-color-editor-inactive-selection-bg: var(--dh-color-gray-200);

packages/console/src/monaco/MonacoTheme.module.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@
4242

4343
//editor
4444
editor-line-number-foreground: var(--dh-color-editor-line-number-fg);
45+
editor-line-number-active-foreground: var(
46+
--dh-color-editor-line-number-active-fg
47+
);
4548
editor-selection-background: var(--dh-color-editor-selection-bg);
4649
editor-inactive-selection-background: var(
4750
--dh-color-editor-inactive-selection-bg

packages/console/src/monaco/MonacoUtils.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ class MonacoUtils {
136136
MonacoTheme['editor-line-highlight-background'],
137137
'editorLineNumber.foreground':
138138
MonacoTheme['editor-line-number-foreground'],
139+
'editorLineNumber.activeForeground':
140+
MonacoTheme['editor-line-number-active-foreground'],
139141
'editor.selectionBackground': MonacoTheme['editor-selection-background'],
140142
'editor.inactiveSelectionBackground':
141143
MonacoTheme['editor-inactive-selection-background'],
2.16 KB
Loading
2.26 KB
Loading
1.83 KB
Loading

0 commit comments

Comments
 (0)