Address self-review

Author: vbabich

package-lock.json

@@ -34,7 +34,6 @@
     "@deephaven/dashboard-core-plugins": "file:../dashboard-core-plugins",
     "@deephaven/file-explorer": "file:../file-explorer",
     "@deephaven/golden-layout": "file:../golden-layout",
-    "@deephaven/grid": "file:../grid",
     "@deephaven/icons": "file:../icons",
     "@deephaven/iris-grid": "file:../iris-grid",
     "@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",

packages/app-utils/package.json

@@ -19,6 +19,11 @@ const { default: loadRemoteModule } = require('./loadRemoteModule') as {
 describe('loadModulePlugins', () => {
   const BASE_URL = 'http://localhost:4100/plugins';
 
+  // Snapshot the resolve map and global.fetch once so each test starts
+  // from a known baseline regardless of what previous tests added.
+  const originalResolveKeys = new Set(Object.keys(resolve));
+  const originalFetch = global.fetch;
+
   function makePlugin(name: string): Plugin {
     return { name, type: PluginType.WIDGET_PLUGIN };
   }
@@ -34,18 +39,18 @@ describe('loadModulePlugins', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
-    // Clean up any plugin entries added to resolve in previous tests
+    // Remove any keys added to the shared resolve map by previous tests
     Object.keys(resolve).forEach(key => {
-      if (
-        key.startsWith('test-plugin') ||
-        key.startsWith('@deephaven/js-plugin-test-plugin') ||
-        key.startsWith('@acme/')
-      ) {
+      if (!originalResolveKeys.has(key)) {
         delete resolve[key];
       }
     });
   });
 
+  afterEach(() => {
+    global.fetch = originalFetch;
+  });
+
   it('loads plugins sequentially and registers them in the plugin map', async () => {
     const pluginA = makePlugin('test-plugin-a');
     const pluginB = makePlugin('test-plugin-b');

packages/app-utils/src/plugins/PluginUtils.test.ts

@@ -172,10 +172,11 @@ const plugins = new Map([
 ## Rules
 
 1. **A base plugin is required.** Middleware registered for a type with no base plugin has no effect and produces a warning.
-2. **Last base plugin wins.** If multiple non-middleware plugins register for the same type, the last one replaces earlier ones (with a warning).
-3. **Middleware must render `Component`.** If a middleware doesn't render the `Component` prop, the rest of the chain (including the base widget) will not appear.
-4. **Middleware must spread props.** Pass all received props to `Component` to ensure the base widget and other middleware receive them.
-5. **`panelComponent` middleware is separate.** When the base plugin defines a `panelComponent`, only middleware that also defines `panelComponent` is applied. Middleware with only `component` is silently skipped in the panel path — it will have no effect for that widget type.
+2. **Last base plugin wins (per widget type).** If multiple non-middleware plugins register for the same widget type, the last one replaces earlier ones (with a warning). This is widget-type resolution in `WidgetLoaderPlugin`, distinct from plugin-name collisions in the plugin map (see below).
+3. **First plugin name wins (in the plugin map).** When `registerPlugin` encounters a plugin name that is already in the plugin map, the duplicate is **skipped** and a warning is logged. The first registration is kept.
+4. **Middleware must render `Component`.** If a middleware doesn't render the `Component` prop, the rest of the chain (including the base widget) will not appear.
+5. **Middleware must spread props.** Pass all received props to `Component` to ensure the base widget and other middleware receive them.
+6. **`panelComponent` middleware is separate.** When the base plugin defines a `panelComponent`, only middleware that also defines `panelComponent` is applied. Middleware with only `component` is silently skipped in the panel path — it will have no effect for that widget type.
 
 ## Cross-Plugin Dependencies
 

packages/plugin/docs/middleware-architecture.md

@@ -48,14 +48,6 @@ export function WidgetView({ fetch, type }: WidgetViewProps): JSX.Element {
       }
     });
 
-    log.debug(
-      `WidgetView resolved plugins for type ${type}:`,
-      'base=',
-      foundBasePlugin?.name ?? 'none',
-      'middleware=',
-      foundMiddleware.map(m => m.name)
-    );
-
     return { basePlugin: foundBasePlugin, middleware: foundMiddleware };
   }, [plugins, type]);
 
@@ -68,10 +60,6 @@ export function WidgetView({ fetch, type }: WidgetViewProps): JSX.Element {
   }, [basePlugin, middleware, type]);
 
   if (ChainedComponent != null) {
-    log.debug(
-      `Rendering chained component for type ${type}:`,
-      ChainedComponent.displayName ?? ChainedComponent.name
-    );
     return <ChainedComponent fetch={fetch} />;
   }