Skip to content

Commit 6088707

Browse files
committed
Just remove @deephaven/log from golden-layout
- Couldn't get the ignore to work, not interested in rewiring it right now - The event still gets logged with the LogProxy and still appears in the exported support logs.
1 parent aaada44 commit 6088707

4 files changed

Lines changed: 3 additions & 11 deletions

File tree

package-lock.json

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/golden-layout/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
"type": "module",
1212
"dependencies": {
1313
"@deephaven/components": "file:../components",
14-
"@deephaven/log": "file:../log",
1514
"jquery": "^3.6.0"
1615
},
1716
"peerDependencies": {

packages/golden-layout/src/utils/EventEmitter.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
import Log from '@deephaven/log';
2-
3-
const log = Log.module('EventEmitter');
4-
51
/**
62
* A generic and very fast EventEmitter
73
* implementation. On top of emitting the
@@ -72,7 +68,7 @@ class EventEmitter {
7268
try {
7369
subs[i].fn.apply(ctx, args);
7470
} catch (e) {
75-
log.error('Error while emitting event:', e);
71+
console.error('Error while emitting event:', e);
7672
}
7773
}
7874
}
@@ -86,7 +82,7 @@ class EventEmitter {
8682
try {
8783
allEventSubs[i].fn.apply(ctx, args);
8884
} catch (e) {
89-
log.error('Error while emitting event to allEventSubs:', e);
85+
console.error('Error while emitting event to allEventSubs:', e);
9086
}
9187
}
9288
}

packages/golden-layout/tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@
55
"outDir": "dist/"
66
},
77
"include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.js", "src/**/*.jsx"],
8-
"exclude": ["node_modules"],
9-
"references": [{ "path": "../components" }, { "path": "../log" }]
8+
"exclude": ["node_modules"]
109
}

0 commit comments

Comments
 (0)