Removed polyfills (DH-19067)

Author: bmingles

packages/jsapi-nodejs/README.md

@@ -17,6 +17,10 @@ import path from 'node:path';
 
 import { loadDhModules } from '@deephaven/jsapi-nodejs';
 
+// Polyfills needed if consuming DH as `ESM` module
+globalThis.self = globalThis;
+globalThis.window = globalThis;
+
 const tmpDir = path.join(__dirname, 'tmp');
 
 // Download jsapi from a Deephaven server

packages/jsapi-nodejs/src/loaderUtils.ts

@@ -100,17 +100,6 @@ export async function loadDhModules({
   LoadModuleOptions,
   'serverUrl' | 'storageDir' | 'targetModuleType'
 >): Promise<typeof DhType> {
-  if (targetModuleType === 'esm') {
-    // These will not be needed if we ever update the JSAPI to not rely on
-    // `window` and `self`.
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    globalThis.self = globalThis;
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-    // @ts-ignore
-    globalThis.window = globalThis;
-  }
-
   const coreModule = await loadModules<
     typeof DhType & { default?: typeof DhType }
   >({