requested changes

Author: Zhou-Ziheng

packages/code-studio/src/settings/FormattingSectionContent.tsx

@@ -11,7 +11,6 @@ import debounce from 'lodash.debounce';
 import classNames from 'classnames';
 import { Button, Checkbox } from '@deephaven/components';
 import {
-  DateTimeColumnFormatter,
   IntegerColumnFormatter,
   DecimalColumnFormatter,
   TableUtils,
@@ -63,7 +62,7 @@ interface FormattingSectionContentState {
   showTimeZone: boolean;
   showTSeparator: boolean;
   timeZone: string;
-  defaultDateTimeFormat?: string;
+  defaultDateTimeFormat: string;
   defaultDecimalFormatOptions: FormatOption;
   defaultIntegerFormatOptions: FormatOption;
   truncateNumbersWithPound: boolean;
@@ -76,19 +75,6 @@ export class FormattingSectionContent extends PureComponent<
 > {
   static defaultProps = {
     scrollTo: (): void => undefined,
-    defaults: {
-      defaultDateTimeFormat:
-        DateTimeColumnFormatter.DEFAULT_DATETIME_FORMAT_STRING,
-      defaultDecimalFormatOptions: {
-        defaultFormatString: DecimalColumnFormatter.DEFAULT_FORMAT_STRING,
-      },
-      defaultIntegerFormatOptions: {
-        defaultFormatString: IntegerColumnFormatter.DEFAULT_FORMAT_STRING,
-      },
-      showTimeZone: false,
-      showTSeparator: true,
-      timeZone: DateTimeColumnFormatter.DEFAULT_TIME_ZONE_ID,
-    },
   };
 
   static inputDebounceTime = 250;

packages/dashboard-core-plugins/src/linker/Linker.tsx

@@ -55,7 +55,7 @@ interface StateProps {
   dh: DhType;
   isolatedLinkerPanelId?: string;
   links: Link[];
-  timeZone?: string;
+  timeZone: string;
 }
 
 interface OwnProps {

packages/dashboard-core-plugins/src/panels/ConsolePanel.tsx

@@ -60,7 +60,7 @@ interface ConsolePanelProps extends DashboardPanelProps {
 
   sessionWrapper: SessionWrapper;
 
-  timeZone?: string;
+  timeZone: string;
   unzip?: (file: File) => Promise<JSZipObject[]>;
   plugins: PluginModuleMap;
 }

packages/redux/src/actions.ts

@@ -52,9 +52,7 @@ export const setDefaultWorkspaceSettings: PayloadActionCreator<
   WorkspaceSettings
 > = settings => ({
   type: SET_DEFAULT_WORKSPACE_SETTINGS,
-  payload: {
-    ...settings,
-  },
+  payload: settings,
 });
 
 export const setWorkspaceStorage: PayloadActionCreator<

packages/redux/src/reducers/defaultWorkspaceSettings.ts

@@ -1,5 +1,5 @@
 /**
- * The Server Configs Values retrieved from the Server
+ * Default values for workspace settings. Used when the user has not modified a setting yet.
  */
 import { SET_DEFAULT_WORKSPACE_SETTINGS } from '../actionTypes';
 import { replaceReducer } from './common';