WIP add a TODO to login in the embedded apps

mofojed · mofojed · commit 7cce1125e455 · 2023-04-11T16:37:08.000-04:00
diff --git a/packages/embed-chart/src/App.tsx b/packages/embed-chart/src/App.tsx
@@ -59,6 +59,7 @@ function App(): JSX.Element {
           log.debug(`Starting connection...`);
           const connection = new dh.IdeConnection(websocketUrl);
 
+          // TODO: Need to login here
           log.debug('Loading figure', name, '...');
 
           // Load the figure up.
diff --git a/packages/embed-grid/src/App.tsx b/packages/embed-grid/src/App.tsx
@@ -89,6 +89,7 @@ function App(): JSX.Element {
           if (name == null) {
             throw new Error('No name param provided');
           }
+          // TOOD: Need to login here
 
           // Connect to the Web API server
           const baseUrl = new URL(

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ function App(): JSX.Element {`
`89`	`89`	`if (name == null) {`
`90`	`90`	`throw new Error('No name param provided');`
`91`	`91`	`}`
	`92`	`+ // TOOD: Need to login here`
`92`	`93`
`93`	`94`	`// Connect to the Web API server`
`94`	`95`	`const baseUrl = new URL(`