Skip to content

Commit 816dd85

Browse files
authored
fix: Add back some defaults to dehydrateIrisGridState (#2419)
Removed in #2416 but they may be needed if we're migrating from old saved states. The main reason they're needed even though the type specifies they aren't all optional is some non-TS code in DHE still.
1 parent 8126c69 commit 816dd85

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

packages/iris-grid/src/IrisGridUtils.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@ import {
1616
type FormattingRule,
1717
} from '@deephaven/jsapi-utils';
1818
import Log from '@deephaven/log';
19-
import { assertNotNull, bindAllMethods, EMPTY_MAP } from '@deephaven/utils';
19+
import {
20+
assertNotNull,
21+
bindAllMethods,
22+
EMPTY_ARRAY,
23+
EMPTY_MAP,
24+
} from '@deephaven/utils';
2025
import AggregationUtils from './sidebar/aggregations/AggregationUtils';
2126
import AggregationOperation from './sidebar/aggregations/AggregationOperation';
2227
import { type FilterData, type IrisGridState } from './IrisGrid';
@@ -1162,7 +1167,7 @@ class IrisGridUtils {
11621167
irisGridState: HydratedIrisGridState
11631168
): DehydratedIrisGridState {
11641169
const {
1165-
aggregationSettings,
1170+
aggregationSettings = { aggregations: EMPTY_ARRAY, showOnTop: false },
11661171
advancedFilters,
11671172
customColumnFormatMap,
11681173
isFilterBarShown,
@@ -1172,16 +1177,16 @@ class IrisGridUtils {
11721177
},
11731178
quickFilters,
11741179
customColumns,
1175-
conditionalFormats,
1180+
conditionalFormats = EMPTY_ARRAY,
11761181
reverse,
11771182
rollupConfig,
11781183
showSearchBar,
11791184
searchValue,
1180-
selectDistinctColumns,
1185+
selectDistinctColumns = EMPTY_ARRAY,
11811186
selectedSearchColumns,
11821187
sorts,
11831188
invertSearchColumns,
1184-
pendingDataMap,
1189+
pendingDataMap = EMPTY_MAP,
11851190
frozenColumns,
11861191
columnHeaderGroups,
11871192
partitionConfig,

0 commit comments

Comments
 (0)