Commit 8892074
authored
fix: Update plotly to v2.29, resolve some rendering issues (#1806)
- v2.28 had some fixes for M1 macs, including for the scattergl issue
we've fallen back to scatter for in the past
- Did not resolve the range breaks issue, so that still requires
`scatter` type
- See plotly/plotly.js#3522 for more details
- Needed to uninstall plotly, then reinstall it - until I did, line
plots were not appearing correctly in `scattergl` mode
- Did `npm uninstall react-plotly.js --workspace packages/chart` and
`npm uninstall react-plotly.js --workspace packages/chart` followed by
`npm install plotly.js --workspace packages/chart` and `npm install
react-plotly.js --workspace packages/chart`
- Tested on Linux desktop and M1 mac, ensured plots were appearing
correctly. Will verify e2e tests as well
- ScatterGL seems to render things _slightly_ differently, so snapshots
needed to be updated for a couple plots1 parent c6ef5b3 commit 8892074
7 files changed
Lines changed: 980 additions & 553 deletions
File tree
- packages/chart
- src
- tests/figure.spec.ts-snapshots
0 commit comments