Skip to content

Commit 92b133b

Browse files
authored
refactor: Moved NewTableColumnTypes to jsapi-utils (#2244)
Moved `NewTableColumnTypes` to jsapi-utils resolves #2239
1 parent d2c6eab commit 92b133b

6 files changed

Lines changed: 5 additions & 3 deletions

File tree

packages/console/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"@deephaven/icons": "file:../icons",
3030
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
3131
"@deephaven/jsapi-types": "^1.0.0-dev0.34.0",
32+
"@deephaven/jsapi-utils": "file:../jsapi-utils",
3233
"@deephaven/log": "file:../log",
3334
"@deephaven/react-hooks": "file:../react-hooks",
3435
"@deephaven/storage": "file:../storage",

packages/console/src/csv/CsvTypeParser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import Papa, {
77
} from 'papaparse';
88
// Intentionally using isNaN rather than Number.isNaN
99
/* eslint-disable no-restricted-globals */
10-
import NewTableColumnTypes from './NewTableColumnTypes';
10+
import { NewTableColumnTypes } from '@deephaven/jsapi-utils';
1111
import makeZipStreamHelper from './ZipStreamHelper';
1212

1313
// Initially column types start as unknown

packages/console/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,3 @@ export * from './console-history';
1616
export * from './monaco';
1717
export { default as LogView } from './log/LogView';
1818
export { default as HeapUsage } from './HeapUsage';
19-
export { default as NewTableColumnTypes } from './csv/NewTableColumnTypes';

packages/console/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
{ "path": "../components" },
1212
{ "path": "../jsapi-bootstrap" },
1313
{ "path": "../jsapi-shim" },
14+
{ "path": "../jsapi-utils" },
1415
{ "path": "../log" },
1516
{ "path": "../storage" },
1617
{ "path": "../test-utils" },

packages/console/src/csv/NewTableColumnTypes.ts renamed to packages/jsapi-utils/src/NewTableColumnTypes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* Valid column types to be used for a call to newTable.
33
*/
4-
class NewTableColumnTypes {
4+
export class NewTableColumnTypes {
55
static INTEGER = 'int';
66

77
static LONG = 'long';

packages/jsapi-utils/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export * from './Formatter';
66
export { default as FormatterUtils } from './FormatterUtils';
77
export * from './FormatterUtils';
88
export * from './MessageUtils';
9+
export * from './NewTableColumnTypes';
910
export * from './NoConsolesError';
1011
export * from './SessionUtils';
1112
export * from './Settings';

0 commit comments

Comments
 (0)