Commit 96c326e
committed
fix: stop loading when input filter change has no effect on grid filters
When Ctrl+E clears all filters, the grid's clearAllFilters() removes
quick filters and stops loading. However, the input filter's debounced
clear arrives later, triggering startLoading('Filtering...') in
componentDidUpdate. Since the filters were already cleared,
applyInputFilters() finds no changes, never calls setState, and the
model update/stopLoading never fires - leaving the grid stuck.
Fix: make applyInputFilters() return whether filters actually changed.
If no change occurred, immediately call stopLoading() to cancel the
loading state that was optimistically started.1 parent 2f5f6fa commit 96c326e
1 file changed
Lines changed: 10 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
959 | 959 | | |
960 | 960 | | |
961 | 961 | | |
962 | | - | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
963 | 969 | | |
964 | 970 | | |
965 | 971 | | |
| |||
1671 | 1677 | | |
1672 | 1678 | | |
1673 | 1679 | | |
| 1680 | + | |
1674 | 1681 | | |
1675 | 1682 | | |
1676 | 1683 | | |
1677 | 1684 | | |
1678 | | - | |
| 1685 | + | |
1679 | 1686 | | |
1680 | 1687 | | |
1681 | 1688 | | |
| |||
1704 | 1711 | | |
1705 | 1712 | | |
1706 | 1713 | | |
| 1714 | + | |
1707 | 1715 | | |
1708 | 1716 | | |
1709 | 1717 | | |
| |||
0 commit comments