Skip to content

Commit 9e18773

Browse files
committed
Fix for e2e tests
1 parent c5db1ba commit 9e18773

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

tests/table-operations.spec.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -484,14 +484,13 @@ test('rollup rows and aggregate columns', async ({ page }) => {
484484
await test.step('Rollup another column', async () => {
485485
const intColumn = page.getByRole('button', { name: 'Int', exact: true });
486486
expect(intColumn).toBeTruthy();
487-
// Move mousee off the grid and ensure the hover state gets removed
487+
// Move mouse off the grid and ensure the hover state gets removed
488488
// This is a workaround for React 18 Chrome e2e failing here with the row still hovered after clicking in the side panel
489489
await page.mouse.move(300, 0, { steps: 10 });
490490
await intColumn.dblclick();
491491

492492
await waitForLoadingDone(page);
493493
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();
494-
await page.pause();
495494
});
496495

497496
await test.step('Rollup a double column', async () => {
@@ -531,12 +530,9 @@ test('rollup rows and aggregate columns', async ({ page }) => {
531530
.getByRole('button', { name: 'Edit Columns', exact: true })
532531
.click();
533532

534-
const locator = page.getByText('Double', { exact: true });
535-
// Sometimes this becomes flaky presumably because of the animation
536-
// or some React inner workings causing 2 elements to briefly exist.
537-
// They are identical except their label ID assigned by the component we use.
538-
// Waiting for only 1 to exist should hopefully fix flakiness.
539-
await expect(locator).toHaveCount(1);
533+
const locator = page
534+
.locator('.aggregation-edit')
535+
.getByText('Double', { exact: true });
540536
await locator.click();
541537
await waitForLoadingDone(page);
542538
await expect(page.locator('.iris-grid-column')).toHaveScreenshot();

0 commit comments

Comments
 (0)