Skip to content

Commit a737f68

Browse files
authored
chore: Add buffer as a chart dependency (#1899)
This adds an explicit dependency to `buffer` to `@deephaven/chart` which we currently get implicitly from `browserify` in `golden-layout`. `plotly.js` depends on `typedarray-pool` which depends on `buffer`, but doesn't list it. I opened a PR with `typedarray-pool`, but doesn't seem it's an active repo any more. mikolalysenko/typedarray-pool#11 The docs uses webpack 5 w/ docusaurus and I added `buffer` when adding chart support, so this should be all that's needed. deephaven/deephaven.io@6a8bcf2#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
1 parent b49b506 commit a737f68

2 files changed

Lines changed: 38 additions & 3 deletions

File tree

package-lock.json

Lines changed: 37 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/chart/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"@deephaven/log": "file:../log",
3535
"@deephaven/react-hooks": "file:../react-hooks",
3636
"@deephaven/utils": "file:../utils",
37+
"buffer": "^6.0.3",
3738
"deep-equal": "^2.0.5",
3839
"lodash.debounce": "^4.0.8",
3940
"lodash.set": "^4.3.2",

0 commit comments

Comments
 (0)