Skip to content

Commit a83f745

Browse files
committed
Address Don's suggestions
1 parent b52373f commit a83f745

8 files changed

Lines changed: 12 additions & 22 deletions

File tree

packages/code-studio/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import React, { Suspense } from 'react';
22
import ReactDOM from 'react-dom';
3+
import '@deephaven/components/scss/BaseStyleSheet.scss'; // Do NOT move any lower. This needs to be imported before any other styles
34
import { Provider } from 'react-redux';
45
import { LoadingOverlay, preloadTheme } from '@deephaven/components';
56
import { ApiBootstrap } from '@deephaven/jsapi-bootstrap';
67
import { store } from '@deephaven/redux';
7-
import '@deephaven/components/scss/BaseStyleSheet.scss';
88
import logInit from './log/LogInit';
99

1010
logInit();

packages/embed-widget/src/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React, { Suspense } from 'react';
22
import ReactDOM from 'react-dom';
3-
import '@deephaven/components/scss/BaseStyleSheet.scss';
3+
import '@deephaven/components/scss/BaseStyleSheet.scss'; // Do NOT move any lower. This needs to be imported before any other styles
44
import { LoadingOverlay, preloadTheme } from '@deephaven/components';
55
import { ApiBootstrap } from '@deephaven/jsapi-bootstrap';
66
import './index.scss';

packages/iris-grid/src/IrisGridRenderer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ export class IrisGridRenderer extends GridRenderer {
573573

574574
context.save();
575575

576-
context.font = theme.font;
576+
context.font = theme.filterBarFont;
577577
context.textAlign = 'left';
578578

579579
if (

packages/iris-grid/src/IrisGridTheme.ts

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,8 @@ import IrisGridThemeRaw from './IrisGridTheme.module.scss';
1111

1212
const log = Log.module('IrisGridTheme');
1313

14-
interface IrisGridDensity {
15-
cellHorizontalPadding: number;
16-
headerHorizontalPadding: number;
17-
minColumnWidth: number;
18-
rowHeight: number;
19-
font: string;
20-
headerFont: string;
21-
iconSize: number;
22-
columnHeaderHeight: number;
23-
}
24-
2514
export type IrisGridThemeType = GridThemeType & {
15+
filterBarFont: string;
2616
filterBarCollapsedHeight: number;
2717
filterBarHeight: number;
2818
reverseHeaderBarHeight: number;
@@ -59,8 +49,8 @@ export type IrisGridThemeType = GridThemeType & {
5949
floatingGridRowColor: NullableGridColor;
6050
iconSize: number;
6151
density: {
62-
compact: Partial<IrisGridDensity>;
63-
spacious: Partial<IrisGridDensity>;
52+
compact: Partial<Omit<IrisGridThemeType, 'density'>>;
53+
spacious: Partial<Omit<IrisGridThemeType, 'density'>>;
6454
};
6555
};
6656

@@ -94,6 +84,7 @@ export function createDefaultIrisGridTheme(): IrisGridThemeType {
9484
white: IrisGridTheme.white,
9585
black: IrisGridTheme.black,
9686
font: IrisGridTheme.font,
87+
filterBarFont: IrisGridTheme.font,
9788
headerBackgroundColor: IrisGridTheme['header-bg'],
9889
headerColor: IrisGridTheme['header-color'],
9990
headerSeparatorColor: IrisGridTheme['header-separator-color'],
@@ -202,14 +193,13 @@ export function createDefaultIrisGridTheme(): IrisGridThemeType {
202193

203194
density: {
204195
compact: {
205-
cellHorizontalPadding: 2,
196+
cellHorizontalPadding: 5, // Same as regular set in GridTheme
206197
headerHorizontalPadding: 10,
207198
minColumnWidth: 10,
208199
rowHeight: 16,
209200
font: '11px Fira Sans, sans-serif',
210-
headerFont: '600 11px Fira Sans, sans-serif',
211201
iconSize: 14,
212-
columnHeaderHeight: 24,
202+
columnHeaderHeight: 26,
213203
},
214204
spacious: {
215205
cellHorizontalPadding: 7,

packages/iris-grid/src/__snapshots__/IrisGridTheme.test.ts.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,9 @@ exports[`createDefaultIrisGridTheme should derive the default Iris grid theme 1`
2323
"dateColor": "IrisGridTheme['date-color']",
2424
"density": {
2525
"compact": {
26-
"cellHorizontalPadding": 2,
27-
"columnHeaderHeight": 24,
26+
"cellHorizontalPadding": 5,
27+
"columnHeaderHeight": 26,
2828
"font": "11px Fira Sans, sans-serif",
29-
"headerFont": "600 11px Fira Sans, sans-serif",
3029
"headerHorizontalPadding": 10,
3130
"iconSize": 14,
3231
"minColumnWidth": 10,
@@ -46,6 +45,7 @@ exports[`createDefaultIrisGridTheme should derive the default Iris grid theme 1`
4645
"filterBarExpandedActiveBackgroundColor": "IrisGridTheme['filter-bar-expanded-active-bg']",
4746
"filterBarExpandedActiveCellBackgroundColor": "IrisGridTheme['filter-bar-expanded-active-cell-bg']",
4847
"filterBarExpandedBackgroundColor": "IrisGridTheme['filter-bar-expanded-bg']",
48+
"filterBarFont": "IrisGridTheme['font']",
4949
"filterBarHeight": 30,
5050
"filterBarHorizontalPadding": 4,
5151
"filterBarSeparatorColor": "IrisGridTheme['filter-bar-separator-color']",
-1.97 KB
Loading
-2.68 KB
Loading
-1.87 KB
Loading

0 commit comments

Comments
 (0)