Skip to content

Commit aa02c0b

Browse files
committed
fix: Move @deephaven/redux to be a dependency instead
- Issue when trying to do an `npm install` in another project that depended on @deephaven/dashboard, as the peerDependency would not resolve the "file:../redux" path - Not sure if lerna or npm should automatically be replacing those at publish time? - Was adding redux as a peerDep because we only want one instance of the redux store; otherwise weird bugs can occur that are difficult to track down - It was already the case with @deephaven/dashboard-core-plugins that it was just a dependency, not a peerDependency. Enterprise handled it just by doing deduplication - Just move @deephaven/redux to be a dependency instead of a peerDependency
1 parent de7a110 commit aa02c0b

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

package-lock.json

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/app-utils/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"build:babel": "babel ./src --out-dir ./dist --extensions \".ts,.tsx,.js,.jsx\" --source-maps --root-mode upward"
2323
},
2424
"devDependencies": {
25-
"@deephaven/redux": "file:../redux",
2625
"react": "^17.x",
2726
"react-dom": "^17.x",
2827
"react-redux": "^7.x",
@@ -34,12 +33,12 @@
3433
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
3534
"@deephaven/jsapi-types": "file:../jsapi-types",
3635
"@deephaven/log": "file:../log",
36+
"@deephaven/redux": "file:../redux",
3737
"@paciolan/remote-component": "2.13.0",
3838
"@paciolan/remote-module-loader": "^3.0.2",
3939
"fira": "mozilla/fira#4.202"
4040
},
4141
"peerDependencies": {
42-
"@deephaven/redux": "file:../redux",
4342
"react": "^17.x",
4443
"react-dom": "^17.x",
4544
"react-redux": "^7.x",

packages/dashboard/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"@deephaven/golden-layout": "file:../golden-layout",
2727
"@deephaven/log": "file:../log",
2828
"@deephaven/react-hooks": "file:../react-hooks",
29+
"@deephaven/redux": "file:../redux",
2930
"@deephaven/utils": "file:../utils",
3031
"deep-equal": "^2.0.5",
3132
"lodash.ismatch": "^4.1.1",
@@ -34,14 +35,12 @@
3435
"shortid": "^2.2.16"
3536
},
3637
"peerDependencies": {
37-
"@deephaven/redux": "file:../redux",
3838
"react": "^17.0.0",
3939
"react-dom": "^17.0.0",
4040
"react-redux": "^7.2.4"
4141
},
4242
"devDependencies": {
4343
"@deephaven/mocks": "file:../mocks",
44-
"@deephaven/redux": "file:../redux",
4544
"@deephaven/tsconfig": "file:../tsconfig",
4645
"@types/lodash.ismatch": "^4.4.0"
4746
},

0 commit comments

Comments
 (0)