Commit aa02c0b
committed
fix: Move @deephaven/redux to be a dependency instead
- Issue when trying to do an `npm install` in another project that depended on @deephaven/dashboard, as the peerDependency would not resolve the "file:../redux" path
- Not sure if lerna or npm should automatically be replacing those at publish time?
- Was adding redux as a peerDep because we only want one instance of the redux store; otherwise weird bugs can occur that are difficult to track down
- It was already the case with @deephaven/dashboard-core-plugins that it was just a dependency, not a peerDependency. Enterprise handled it just by doing deduplication
- Just move @deephaven/redux to be a dependency instead of a peerDependency1 parent de7a110 commit aa02c0b
3 files changed
Lines changed: 4 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
| |||
34 | 33 | | |
35 | 34 | | |
36 | 35 | | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | 44 | | |
46 | 45 | | |
47 | 46 | | |
| |||
0 commit comments