Skip to content

Commit c5426ec

Browse files
authored
fix: DH-22054: GridMetrics type update (#2659)
1 parent 3ed691d commit c5426ec

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

packages/iris-grid/src/IrisGridCacheUtils.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const irisGridState = {
5151
metrics: {
5252
userColumnWidths: new Map(),
5353
userRowHeights: new Map(),
54-
} as GridMetrics,
54+
} as Partial<GridMetrics>,
5555
} satisfies HydratedIrisGridState;
5656

5757
describe('makeMemoizedGridStateDehydrator', () => {

packages/iris-grid/src/IrisGridUtils.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ describe('dehydration methods', () => {
719719
metrics: {
720720
userColumnWidths: new Map(),
721721
userRowHeights: new Map(),
722-
} as GridMetrics,
722+
} as Partial<GridMetrics>,
723723
}),
724724
],
725725
])('%s should be serializable', (_label, result) => {

packages/iris-grid/src/IrisGridUtils.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {
2+
type GridMetrics,
23
type GridRange,
34
type GridState,
45
GridUtils,
@@ -76,8 +77,9 @@ export type HydratedIrisGridState = Pick<
7677
| 'conditionalFormats'
7778
| 'columnHeaderGroups'
7879
| 'partitionConfig'
79-
| 'metrics'
80-
>;
80+
> & {
81+
metrics?: Partial<GridMetrics>;
82+
};
8183

8284
export type DehydratedPendingDataMap<T> = [number, { data: [string, T][] }][];
8385

@@ -1192,10 +1194,10 @@ class IrisGridUtils {
11921194
customColumnFormatMap,
11931195
columnAlignmentMap = EMPTY_MAP,
11941196
isFilterBarShown,
1195-
metrics: { userColumnWidths, userRowHeights } = {
1196-
userColumnWidths: EMPTY_MAP,
1197-
userRowHeights: EMPTY_MAP,
1198-
},
1197+
metrics: {
1198+
userColumnWidths = new Map<ModelIndex, number>(),
1199+
userRowHeights = new Map<ModelIndex, number>(),
1200+
} = {},
11991201
quickFilters,
12001202
customColumns,
12011203
conditionalFormats = EMPTY_ARRAY,

0 commit comments

Comments
 (0)