Skip to content

Commit d343b51

Browse files
committed
use classNames
1 parent 2af1e6a commit d343b51

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

packages/iris-grid/src/sidebar/conditional-formatting/ConditionEditor.tsx

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React, { useCallback, useEffect, useMemo, useState } from 'react';
2+
import classNames from 'classnames';
23
import { TableUtils } from '@deephaven/jsapi-utils';
34
import type { dh as DhType } from '@deephaven/jsapi-types';
45
import Log from '@deephaven/log';
@@ -155,7 +156,7 @@ function getNumberInputs(
155156
return (
156157
<input
157158
type="number"
158-
className={`form-control ${isInvalid ? 'is-invalid' : ''}`}
159+
className={classNames('form-control', { 'is-invalid': isInvalid })}
159160
placeholder="Enter value"
160161
value={conditionValue ?? ''}
161162
onChange={handleValueChange}
@@ -166,16 +167,18 @@ function getNumberInputs(
166167
<div className="d-flex flex-row">
167168
<input
168169
type="number"
169-
className={`form-control d-flex mr-2 ${
170-
isInvalid ? 'is-invalid' : ''
171-
}`}
170+
className={classNames('form-control', 'd-flex', 'mr-2', {
171+
'is-invalid': isInvalid,
172+
})}
172173
placeholder="Start value"
173174
value={startValue ?? ''}
174175
onChange={handleStartValueChange}
175176
/>
176177
<input
177178
type="number"
178-
className={`form-control d-flex ${isInvalid ? 'is-invalid' : ''}`}
179+
className={classNames('form-control', 'd-flex', {
180+
'is-invalid': isInvalid,
181+
})}
179182
placeholder="End value"
180183
value={endValue ?? ''}
181184
onChange={handleEndValueChange}
@@ -202,7 +205,7 @@ function getStringInputs(
202205
return (
203206
<input
204207
type="text"
205-
className={`form-control ${isInvalid ? 'is-invalid' : ''}`}
208+
className={classNames('form-control', { 'is-invalid': isInvalid })}
206209
placeholder="Enter value"
207210
value={conditionValue ?? ''}
208211
onChange={handleValueChange}
@@ -225,7 +228,7 @@ function getDateInputs(
225228
return (
226229
<input
227230
type="text"
228-
className={`form-control ${isInvalid ? 'is-invalid' : ''}`}
231+
className={classNames('form-control', { 'is-invalid': isInvalid })}
229232
placeholder="Enter value"
230233
value={conditionValue ?? ''}
231234
onChange={handleValueChange}
@@ -252,7 +255,7 @@ function getCharInputs(
252255
return (
253256
<input
254257
type="text"
255-
className={`form-control ${isInvalid ? 'is-invalid' : ''}`}
258+
className={classNames('form-control', { 'is-invalid': isInvalid })}
256259
maxLength={1}
257260
placeholder="Enter value"
258261
value={conditionValue ?? ''}

0 commit comments

Comments
 (0)