Skip to content

Commit d4c2ad9

Browse files
committed
change aria-labels to readable strings
1 parent 90227c1 commit d4c2ad9

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

packages/iris-grid/src/GotoRow.tsx

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ function GotoRow({
161161
}
162162
}}
163163
value={gotoValue}
164-
aria-label="value-input"
164+
aria-label="Value Input"
165165
/>
166166
</div>
167167
);
@@ -180,7 +180,7 @@ function GotoRow({
180180
defaultValue={gotoValue}
181181
onChange={onGotoValueInputChanged}
182182
onSubmit={handleGotoValueKeySubmit}
183-
aria-label="value-input"
183+
aria-label="Value Input"
184184
/>
185185
</div>
186186
);
@@ -228,7 +228,7 @@ function GotoRow({
228228
placeholder="value"
229229
onChange={e => onGotoValueInputChanged(e.target.value)}
230230
value={gotoValue}
231-
aria-label="value-input"
231+
aria-label="Value Input"
232232
/>
233233
</div>
234234
</>
@@ -242,7 +242,7 @@ function GotoRow({
242242
onGotoValueInputChanged(event.target.value);
243243
}}
244244
value={gotoValue}
245-
aria-label="value-input"
245+
aria-label="Value Input"
246246
>
247247
<option aria-label="null value" key="null" value="" />
248248
<option key="true" value="true">
@@ -264,7 +264,7 @@ function GotoRow({
264264
placeholder="value"
265265
onChange={e => onGotoValueInputChanged(e.target.value)}
266266
value={gotoValue}
267-
aria-label="value-input"
267+
aria-label="Value Input"
268268
/>
269269
</div>
270270
);
@@ -331,17 +331,15 @@ function GotoRow({
331331
</div>
332332
{model.isSeekRowAvailable && (
333333
<div className="goto-row-row">
334-
<fieldset
334+
<div
335335
className={classNames('goto-row-wrapper', {
336336
'is-inactive': isGotoRowActive,
337337
})}
338338
onClick={() => setIsGotoRowActive(false)}
339339
onFocus={() => setIsGotoRowActive(false)}
340340
role="group"
341341
>
342-
<div>
343-
<legend className="goto-row-text">Go to value</legend>
344-
</div>
342+
<div className="goto-row-text">Go to value</div>
345343
<div className="goto-row-input">
346344
<select
347345
className="custom-select"
@@ -385,7 +383,7 @@ function GotoRow({
385383
{gotoValueError && (
386384
<div className="text-danger">{gotoValueError}</div>
387385
)}
388-
</fieldset>
386+
</div>
389387
</div>
390388
)}
391389
</>

0 commit comments

Comments
 (0)