Skip to content

Commit d852e49

Browse files
dsmmckenmofojed
andauthored
feat: Improve text labels based on suggestions from chatGPT (#1118)
I asked chatGPT to help me brainstorm improvements to some of the labels and hint text based on the Apple Human Interface Guidelines. I then edited them as human to improve them further. Review and let me know if you think any are worse or weird. --------- Co-authored-by: Mike Bender <mikebender@deephaven.io>
1 parent 4ed5787 commit d852e49

8 files changed

Lines changed: 16 additions & 20 deletions

File tree

packages/code-studio/src/settings/ColumnSpecificSectionContent.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -614,10 +614,9 @@ export class ColumnSpecificSectionContent extends PureComponent<
614614

615615
return (
616616
<div className="app-settings-formatting-section" ref={this.containerRef}>
617-
<div>Default formatting for matched column names</div>
618617
<div className="app-settings-menu-description mb-3">
619-
Applies a formatting rule to all columns that match a specified name
620-
and type.
618+
Customize the formatting of table columns by applying rules based on
619+
matching both a column name and column type.
621620
</div>
622621

623622
<TransitionGroup

packages/code-studio/src/settings/FormattingSectionContent.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,9 +429,9 @@ export class FormattingSectionContent extends PureComponent<
429429
return (
430430
<div className="app-settings-formatting-section" ref={this.containerRef}>
431431
<div className="container-fluid p-0">
432-
<div>Default formatting for column types</div>
433432
<div className="app-settings-menu-description mb-3">
434-
Applies a formatting rule to all columns of a set type.
433+
Choose the default formatting rule to apply to all table columns
434+
based on their type.
435435
</div>
436436
<div className="form-row mb-2">
437437
<label

packages/code-studio/src/settings/SettingsMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ export class SettingsMenu extends Component<
143143
transform="grow-4"
144144
className="mr-2"
145145
/>
146-
Default Formatting &amp; Time zone
146+
Default Format &amp; Time zone
147147
</>
148148
}
149149
onToggle={this.handleSectionToggle}
@@ -163,7 +163,7 @@ export class SettingsMenu extends Component<
163163
transform="grow-4"
164164
className="mr-2"
165165
/>
166-
Column Specific Formatting Rules
166+
Format by Column Name &amp; Type
167167
</>
168168
}
169169
onToggle={this.handleSectionToggle}

packages/code-studio/src/settings/ShortcutsSectionContent.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ function ShortcutSectionContent({
6262
return (
6363
<>
6464
<div className="app-settings-menu-description">
65-
Customize shortcuts below. Assigning shortcuts that conflict with the
66-
browser or IDE shortcuts may cause unintended behavior
65+
Customize shortcuts below. To prevent unexpected results, avoid
66+
conflicting shortcuts with the browser or IDE editor.
6767
</div>
6868
{categories.map(category => (
6969
<ShortcutCategory

packages/iris-grid/src/IrisGrid.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1075,7 +1075,7 @@ export class IrisGrid extends Component<IrisGridProps, IrisGridState> {
10751075
}
10761076
optionItems.push({
10771077
type: OptionType.VISIBILITY_ORDERING_BUILDER,
1078-
title: 'Hide, Group, and Order Columns',
1078+
title: 'Organize Columns',
10791079
icon: dhEye,
10801080
});
10811081
if (isFormatColumnsAvailable) {

packages/iris-grid/src/sidebar/AdvancedSettingsMenu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ AdvancedSettingsMenu.getAdvancedSettingsTitleForKey = (
3434
): string => {
3535
switch (key) {
3636
case AdvancedSettingsType.FILTER_CONTROL_CHANGE_CLEARS_ALL_FILTERS:
37-
return 'Control filters clear existing table filters';
37+
return 'Clear current table filters before applying new filters from a control';
3838
case AdvancedSettingsType.LINK_CHANGE_CLEARS_ALL_FILTERS:
39-
return 'Inbound links clear existing table filters';
39+
return 'Clear current table filters before applying new filters from an incoming link filter';
4040
}
4141
};
4242

packages/iris-grid/src/sidebar/RollupRows.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,8 @@ class RollupRows extends Component<RollupRowsProps, RollupRowsState> {
517517
// eslint-disable-next-line react/jsx-props-no-spreading
518518
{...provided.droppableProps}
519519
>
520-
Create rollup by dragging columns here, from the available
521-
columns list below.
520+
To create a rollup, drag columns from the list below and
521+
drop them into this area.
522522
</div>
523523
)}
524524
</Droppable>

packages/iris-grid/src/sidebar/SelectDistinctBuilder.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,9 @@ class SelectDistinctBuilder extends Component<
161161

162162
<div className="select-distinct-builder-footer">
163163
<div className="select-distinct-builder-hint">
164-
Modifies a table to show unique value from a column, same as{' '}
165-
<span className="inline-code-snippet">
166-
selectDistinct(&quot;Column&quot;)
167-
</span>
168-
. Filters will be reset and the resulting table will contain only
169-
the selected columns above.
164+
Display only unique values from the selected table columns. Note
165+
that this will reset any filters and display only the selected
166+
columns.
170167
</div>
171168
</div>
172169
</div>

0 commit comments

Comments
 (0)