Skip to content

Commit da572d1

Browse files
authored
fix: allow input table to delete row with null key (#2386)
https://deephaven.atlassian.net/browse/DH-18681 IrisGridTableModel was failing to create a filter on a `null` key. Updated to use the nullable util method.
1 parent 8c8983b commit da572d1

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

packages/iris-grid/src/IrisGridTableModel.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -427,11 +427,7 @@ class IrisGridTableModel
427427
for (let c = 0; c < keyColumns.length; c += 1) {
428428
const column = keyColumns[c];
429429
const value = row[c];
430-
const filterValue = this.tableUtils.makeFilterRawValue(
431-
column.type,
432-
value
433-
);
434-
const filter = column.filter().eq(filterValue);
430+
const filter = this.tableUtils.makeNullableEqFilter(column, value);
435431
columnFilters.push(filter);
436432
}
437433
return columnFilters.reduce((agg, curr) => agg?.and(curr) ?? curr);

0 commit comments

Comments
 (0)