refactor: Change embed-grid and embed-chart to redirects (#1873)

Publishing an alpha with the `embed-refactor` label so we can test with
a local DHC build

This changes embed-grid and embed-chart to just be simple redirects to
`/iframe/widget`. This should reduce our footprint in the install size
as this is about half of the size we contribute currently.

BREAKING CHANGE: `@deephaven/embed-grid` does not handle messages to the
iframe for filtering or sorting the grid any more

Author: mattrunyon

README.md

@@ -40,10 +40,10 @@ We use Chrome for development with the React and Redux extensions.
 ## Scripts
 
 - `npm install` : Install all dependencies and automatically bootstrap packages. Should be run before any of the other steps.
-- `npm start`: Start building all packages and watching them (when possible). Use when you're developing, and your changes will be picked up automatically. Servers will open up for code-studio, embed-grid, embed-chart, and embed-widget. These will open on localhost on ports 4000, 4010, 4020, and 4030 respectively.
+- `npm start`: Start building all packages and watching them (when possible). Use when you're developing, and your changes will be picked up automatically. Servers will open up for code-studio and embed-widget. These will open on localhost on ports 4000 and 4010 respectively.
 - `npm test`: Start running tests in all packages and watching (when possible). Use when you're developing, and any breaking changes will be printed out automatically. See [Unit tests](#unit-tests) for more details.
 - `npm run build`: Create a production build of all packages. Mainly used by CI when packaging up a production version of the app.
-- `npm run preview`: Runs the Vite preview server for the built code-studio, embed-grid, embed-chart, and embed-widget. These will open on ports 4000, 4010, 4020, and 4030 respectively.
+- `npm run preview`: Runs the Vite preview server for the built code-studio and embed-widget. These will open on ports 4000 and 4010 respectively.
 - `npm run e2e`: Runs the Playwright end-to-end tests locally. See [E2E Tests](#e2e-tests) for more details.
 
 If your DHC address is different from the default `http://localhost:10000`, edit `.env.local` in each package to point to your local DHC. This is needed for the session websocket and for things like notebooks to be proxied correctly by Vite.
@@ -115,7 +115,7 @@ Depending on what your package is, there are a couple of different templates tha
 
 ### Application package
 
-A standalone application with it's own entry point. Recommend copying the [embed-grid](./packages/embed-grid/) package, removing any dependencies and files not required.
+A standalone application with it's own entry point. Recommend copying the [embed-widget](./packages/embed-widget/) package, removing any dependencies and files not required.
 
 ### Component/library package
 

package.json

@@ -26,20 +26,16 @@
     "build": "run-s build:necessary types build:packages build:apps",
     "build:apps": "lerna run --scope=@deephaven/{code-studio,embed-chart,embed-grid,embed-widget} build",
     "build:app": "lerna run --scope=@deephaven/code-studio build",
-    "build:embed-chart": "lerna run --scope=@deephaven/embed-chart build",
-    "build:embed-grid": "lerna run --scope=@deephaven/embed-grid build",
     "build:embed-widget": "lerna run --scope=@deephaven/embed-widget build",
     "build:packages": "lerna run --ignore=@deephaven/{code-studio,embed-chart,embed-grid,embed-widget} build --stream",
     "build:profile": "lerna run build --stream --profile",
     "build:necessary": "lerna run build --scope=@deephaven/icons",
     "analyze": "lerna run analyze",
-    "preview": "lerna run --scope=@deephaven/{code-studio,embed-chart,embed-grid,embed-widget} preview --stream",
+    "preview": "lerna run --scope=@deephaven/{code-studio,embed-widget} preview --stream",
     "preview:app": "lerna run --scope=@deephaven/code-studio preview --stream",
     "prestart": "npm run build:necessary",
     "start": "run-p watch:types start:*",
     "start:app": "lerna run start --scope=@deephaven/code-studio --stream",
-    "start:embed-chart": "lerna run start --scope=@deephaven/embed-chart --stream",
-    "start:embed-grid": "lerna run start --scope=@deephaven/embed-grid --stream",
     "start:embed-widget": "lerna run start --scope=@deephaven/embed-widget --stream",
     "pretest": "npm run build:necessary",
     "test": "jest --watch --changedSince origin/main",

packages/embed-chart/.env

@@ -1,23 +1,5 @@
 # Embedded Deephaven Chart
 
-This project uses [Vite](https://vitejs.dev/guide/). It is to provide an example React application connecting to Deephaven and displaying a chart or plot.
+### Deprecated
 
-## Running
-
-To start the Embed Chart server, run `npm install` and `npm start` in the root directory of this repository. See the [Getting Started](../../README.md#getting-started) section for more details.
-
-## Query Parameters
-
-- `name`: Required. The name of the chart to load
-
-## Advanced
-
-### Application Mode
-
-See the guide for how to set up core in Application Mode: https://deephaven.io/core/docs/how-to-guides/application-mode/
-
-Once Deephaven is running, you can open a chart with a specific name by adding the query param `name`, e.g. http://localhost:4020/?name=world
-
-### Configuring Server Address
-
-By default, this project assumes you are hosting Deephaven with Python on the default port at http://localhost:10000. If Deephaven is running on a different port/server, update the `VITE_CORE_API_URL` environment variable to point to the correct server. See [.env](./.env) file for the default definition, and [vite docs](https://vitejs.dev/guide/env-and-mode.html#env-variables-and-modes) for other ways to set this environment variable.
+Use [@deephaven/embed-widget](https://www.npmjs.com/package/@deephaven/embed-widget) instead.

packages/embed-chart/.env.development

@@ -1,22 +1,16 @@
 <!doctype html>
 <html lang="en">
   <head>
-    <base href="%BASE_URL%" />
-    <meta name="ui-version" content="v%npm_package_version%" />
-    <meta charset="utf-8" />
-    <meta
-      name="viewport"
-      content="width=device-width, initial-scale=1, shrink-to-fit=no"
-    />
-    <meta name="theme-color" content="#2d2a2e" />
-    <link rel="manifest" href="/manifest.json" />
-
-    <link rel="icon" href="%VITE_FAVICON%" />
-    <title>Deephaven Embedded Chart</title>
+    <base href="./" />
   </head>
   <body>
-    <noscript> You need to enable JavaScript to run this app. </noscript>
-    <div id="root"></div>
-    <script type="module" src="/src/index.tsx"></script>
+    <noscript>You need to enable JavaScript to run this app.</noscript>
+
+    <script>
+      // Can't be an HTML meta redirect because we need to keep the search params
+      const url = new URL('../widget/', document.baseURI);
+      url.search = window.location.search;
+      window.location.replace(url);
+    </script>
   </body>
 </html>

packages/embed-chart/.prettierignore

@@ -11,35 +11,12 @@
     "directory": "packages/embed-chart"
   },
   "homepage": ".",
-  "main": "public/index.js",
+  "scripts": {
+    "build": "vite build --outDir build"
+  },
   "files": [
     "build"
   ],
-  "dependencies": {
-    "@deephaven/app-utils": "file:../app-utils",
-    "@deephaven/chart": "file:../chart",
-    "@deephaven/components": "file:../components",
-    "@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
-    "@deephaven/jsapi-components": "file:../jsapi-components",
-    "@deephaven/jsapi-types": "1.0.0-dev0.33.1",
-    "@deephaven/jsapi-utils": "file:../jsapi-utils",
-    "@deephaven/log": "file:../log",
-    "fira": "mozilla/fira#4.202",
-    "react": "^17.0.2",
-    "react-dom": "^17.0.2"
-  },
-  "scripts": {
-    "analyze": "source-map-explorer build/assets/*.js --no-border-checks",
-    "start": "vite",
-    "build": "NODE_OPTIONS='--max-old-space-size=4096' vite build",
-    "preview": "vite preview"
-  },
-  "devDependencies": {
-    "@deephaven/eslint-config": "file:../eslint-config",
-    "@deephaven/mocks": "file:../mocks",
-    "@deephaven/prettier-config": "file:../prettier-config",
-    "@deephaven/stylelint-config": "file:../stylelint-config"
-  },
   "publishConfig": {
     "access": "public"
   }