fix: Load full uncoalesced table if no partition columns available (#1767)

mofojed · web-flow · commit e6dd3e16a601 · 2024-02-01T20:16:11.000Z
- When there are no partition columns, we should just load the whole table instead of hanging - Tested with the snippet in the ticket - Fixes #1763
diff --git a/packages/iris-grid/src/IrisGridTableModel.ts b/packages/iris-grid/src/IrisGridTableModel.ts
@@ -285,7 +285,11 @@ class IrisGridTableModel
   }
 
   get isPartitionRequired(): boolean {
-    return this.table.isUncoalesced && this.isValuesTableAvailable;
+    return (
+      this.table.isUncoalesced &&
+      this.isValuesTableAvailable &&
+      this.partitionColumns.length > 0
+    );
   }
 
   isFilterable(columnIndex: ModelIndex): boolean {

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,11 @@ class IrisGridTableModel`
`285`	`285`	`}`
`286`	`286`
`287`	`287`	`get isPartitionRequired(): boolean {`
`288`		`- return this.table.isUncoalesced && this.isValuesTableAvailable;`
	`288`	`+ return (`
	`289`	`+ this.table.isUncoalesced &&`
	`290`	`+ this.isValuesTableAvailable &&`
	`291`	`+ this.partitionColumns.length > 0`
	`292`	`+ );`
`289`	`293`	`}`
`290`	`294`
`291`	`295`	`isFilterable(columnIndex: ModelIndex): boolean {`