fix: Console does not scroll to bottom when code run from notebook (#2114)

mattrunyon · web-flow · commit e75e716a2d18 · 2024-06-27T15:18:34.000-05:00
Noticed running code from a notebook wasn't scrolling to the bottom on Chrome on Linux at least.
diff --git a/packages/console/src/Console.tsx b/packages/console/src/Console.tsx
@@ -655,7 +655,10 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {
     if (pane == null) {
       return;
     }
-    pane.scrollTo({ top: pane.scrollHeight });
+
+    window.requestAnimationFrame(() => {
+      pane.scrollTo({ top: pane.scrollHeight });
+    });
   }
 
   handleScrollPaneScroll(): void {

Original file line number	Diff line number	Diff line change
`@@ -655,7 +655,10 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {`
`655`	`655`	`if (pane == null) {`
`656`	`656`	`return;`
`657`	`657`	`}`
`658`		`- pane.scrollTo({ top: pane.scrollHeight });`
	`658`	`+`
	`659`	`+ window.requestAnimationFrame(() => {`
	`660`	`+ pane.scrollTo({ top: pane.scrollHeight });`
	`661`	`+ });`
`659`	`662`	`}`
`660`	`663`
`661`	`664`	`handleScrollPaneScroll(): void {`