Commit f1f3abf
authored
feat: Add signatureHelp and hover providers to monaco (#1178)
Corresponds with deephaven/deephaven-core#3607
This adds signatureHelp and hover providers if the JS API supports the
corresponding requests
SignatureHelp is provided when you type a method and then type the `(`
character. There's also probably a keybinding in monaco to trigger it,
but I'm not sure what it is.
Hover provided when you hover anything
Needs to use [my core
branch](https://github.com/mattrunyon/deephaven-core/tree/lsp-improvements)
to test. After pulling that branch, will need to build/install the
Python server using the following commands
```
./gradlew :py-server:assemble :py-embedded-server:assemble
pip install --force-reinstall py/server/build/wheel/deephaven_core-0.23.0-py3-none-any.whl py/embedded-server/build/wheel/deephaven_server-0.23.0-py3-none-any.whl
```
Then start using one of these commands. Groovy provided just to show it
doesn't break anything in Groovy. There is no autocomplete in Python
notebooks if you are using a Groovy worker.
```
./gradlew server-jetty-app:run # Python
START_OPTS="-Ddeephaven.console.type=groovy" ./gradlew server-jetty-app:run # Groovy
```1 parent 3a11322 commit f1f3abf
10 files changed
Lines changed: 786 additions & 239 deletions
File tree
- __mocks__
- packages
- components/scss
- console/src
- monaco
- notebook
- jsapi-types/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1536 | 1536 | | |
1537 | 1537 | | |
1538 | 1538 | | |
| 1539 | + | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
1539 | 1545 | | |
1540 | 1546 | | |
1541 | 1547 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
677 | 677 | | |
678 | 678 | | |
679 | 679 | | |
680 | | - | |
| 680 | + | |
| 681 | + | |
681 | 682 | | |
682 | 683 | | |
683 | 684 | | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
684 | 693 | | |
685 | 694 | | |
686 | 695 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
513 | 513 | | |
514 | 514 | | |
515 | 515 | | |
516 | | - | |
| 516 | + | |
517 | 517 | | |
518 | 518 | | |
519 | 519 | | |
| |||
Lines changed: 0 additions & 98 deletions
This file was deleted.
Lines changed: 0 additions & 134 deletions
This file was deleted.
0 commit comments