Skip to content

Commit fa3a33d

Browse files
authored
fix: address chrome 121 scrollbar style behaviour change (#1787)
Chrome adopted offical support for scrollbar-color in chrome 121. However, if you have both scrollbar-color and ::webkit-scrollbar styling, they conflict and chrome will only honour the native styling. This is bad because the native chrome mac scrollbars become really small, and overlap too much with out golden-layout drag. Our webkit styling forces scrollbars that match monaco and grid, and are preferred. By removing `scrollbar-color` native styling, our webkit styles work. We only had scrollbar-color to style firefox in dark mode (`//applies to firefox only` is no longer true), however the most recent versions of firefox appear to color scrollbars automatically based on the theme, so this is no longer necessary. The crappy part here is since this is browser change, we will have to backport this for several active enterprise versions. See: - https://stackoverflow.com/questions/77919700/scrollbars-chrome-update-121 - https://issues.chromium.org/issues/41494676
1 parent 434930a commit fa3a33d

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

packages/components/scss/BaseStyleSheet.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ body {
4545
padding: 0;
4646
overscroll-behavior: none;
4747
-ms-scroll-chaining: none;
48-
scrollbar-color: fg-opacity(10) bg-opacity(10); //applies to firefox only
4948
}
5049

5150
#root {

0 commit comments

Comments
 (0)