Clean up based on review

Author: mofojed

packages/console/src/Console.tsx

@@ -56,8 +56,8 @@ interface ConsoleProps {
   /** Additional children to show in the objects menu */
   statusBarChildren: ReactNode;
 
-  /** Hide the objects menu in the status bar. Defaults to false. */
-  hideObjectsMenu?: boolean;
+  /** Show the objects menu in the status bar. Defaults to true. */
+  showObjectsMenu?: boolean;
 
   settings: Partial<Settings>;
   focusCommandHistory: () => void;
@@ -148,6 +148,7 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {
     unzip: null,
     supportsType: defaultSupportsType,
     iconForType: defaultIconForType,
+    showObjectsMenu: true,
   };
 
   static LOG_THROTTLE = 500;
@@ -996,7 +997,7 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {
       unzip,
       supportsType,
       iconForType,
-      hideObjectsMenu,
+      showObjectsMenu,
     } = this.props;
     const {
       consoleHeight,
@@ -1025,7 +1026,7 @@ export class Console extends PureComponent<ConsoleProps, ConsoleState> {
             overflowActions={this.handleOverflowActions}
           >
             {statusBarChildren}
-            {hideObjectsMenu !== true && (
+            {showObjectsMenu === true && (
               <ConsoleObjectsMenu
                 openObject={openObject}
                 objects={consoleMenuObjects}

packages/console/src/ConsoleObjectsMenu.tsx

@@ -8,6 +8,7 @@ import {
 } from '@deephaven/components';
 import { vsGraph, vsTriangleDown } from '@deephaven/icons';
 import type { dh as DhType } from '@deephaven/jsapi-types';
+import { EMPTY_FUNCTION } from '@deephaven/utils';
 import { ObjectIcon } from './common';
 
 interface ConsoleObjectsMenuProps {
@@ -40,7 +41,7 @@ function ConsoleObjectsMenu({
     };
     const filteredObjects = filterText
       ? objects.filter(
-          ({ title }: { title?: string }) =>
+          ({ title }) =>
             title != null &&
             title.toLowerCase().includes(filterText.toLowerCase())
         )
@@ -60,9 +61,7 @@ function ConsoleObjectsMenu({
       aria-label="Objects"
       kind="ghost"
       disabled={objects.length === 0}
-      onClick={() => {
-        // no-op: click is handled in `DropdownMenu`
-      }}
+      onClick={EMPTY_FUNCTION}
       tooltip={objects.length === 0 ? 'No objects available' : 'Objects'}
       icon={
         <div className="fa-md fa-layers">
@@ -78,7 +77,9 @@ function ConsoleObjectsMenu({
       <DropdownMenu
         actions={actions}
         onMenuOpened={() => searchRef.current?.focus()}
-        onMenuClosed={() => setFilterText('')}
+        onMenuClosed={() => {
+          searchRef.current?.focus();
+        }}
         options={{ initialKeyboardIndex: 1 }}
         popperOptions={{ placement: 'bottom-end' }}
       />

packages/console/src/ConsoleStatusBar.tsx

@@ -16,6 +16,7 @@ import {
   Tooltip,
 } from '@deephaven/components';
 import './ConsoleStatusBar.scss';
+import { EMPTY_FUNCTION } from '@deephaven/utils';
 
 const POPPER_OPTIONS: PopperOptions = { placement: 'bottom-end' };
 
@@ -32,19 +33,19 @@ function ConsoleStatusBar({
   session,
   overflowActions,
 }: ConsoleStatusBarProps): ReactElement {
-  const [isCommandRunning, setIsCommandRunning] = useState(false);
+  const [pendingCommandCount, setPendingCommandCount] = useState(0);
 
   const handleCommandStarted = useCallback(async (event: CustomEvent) => {
-    setIsCommandRunning(true);
+    setPendingCommandCount(count => count + 1);
 
-    const { result } = event.detail;
     try {
+      const { result } = event.detail;
       await result;
     } catch (error) {
       // No-op, fall through
     }
 
-    setIsCommandRunning(false);
+    setPendingCommandCount(count => count - 1);
   }, []);
 
   useEffect(
@@ -66,7 +67,7 @@ function ConsoleStatusBar({
 
   let statusIconClass = null;
   let tooltipText = null;
-  if (isCommandRunning) {
+  if (pendingCommandCount > 0) {
     // Connected, Pending
     statusIconClass = 'console-status-icon-pending';
     tooltipText = 'Worker is busy';
@@ -93,9 +94,7 @@ function ConsoleStatusBar({
           icon={vsKebabVertical}
           tooltip="More Actions..."
           aria-label="More Actions..."
-          onClick={() => {
-            // no-op: click is handled in `DropdownMenu`
-          }}
+          onClick={EMPTY_FUNCTION}
         >
           <DropdownMenu
             actions={overflowActions}

packages/dashboard-core-plugins/src/panels/ConsolePanel.tsx

@@ -440,7 +440,7 @@ export class ConsolePanel extends PureComponent<
                 />
               </>
             }
-            hideObjectsMenu
+            showObjectsMenu={false}
             scope={sessionId}
             timeZone={timeZone}
             objectMap={objectMap}