Skip to content

feat: Expandable rows shows tooltip#1068

Merged
emilyhuxng merged 3 commits intodeephaven:mainfrom
emilyhuxng:expandable-rows-shows-tooltip
Feb 3, 2023
Merged

feat: Expandable rows shows tooltip#1068
emilyhuxng merged 3 commits intodeephaven:mainfrom
emilyhuxng:expandable-rows-shows-tooltip

Conversation

@emilyhuxng
Copy link
Copy Markdown
Contributor

Closes #1061

Upon hovering an expandable row, display a tooltip with instructions on how to expand or expand all children. The tooltip closes on any action but shows again if you move on the expandable row.

@emilyhuxng emilyhuxng added this to the February 2023 milestone Feb 3, 2023
@emilyhuxng emilyhuxng requested a review from mofojed February 3, 2023 14:51
@emilyhuxng emilyhuxng self-assigned this Feb 3, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2023

Codecov Report

Merging #1068 (6475109) into main (69266f2) will decrease coverage by 0.09%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
- Coverage   41.94%   41.86%   -0.09%     
==========================================
  Files         431      432       +1     
  Lines       32477    32555      +78     
  Branches     8176     8191      +15     
==========================================
+ Hits        13622    13628       +6     
- Misses      18802    18874      +72     
  Partials       53       53              
Flag Coverage Δ
unit 41.86% <7.69%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/mousehandlers/IrisGridRowTreeMouseHandler.ts 5.66% <5.66%> (ø)
packages/iris-grid/src/IrisGridRenderer.ts 24.36% <7.14%> (-0.49%) ⬇️
packages/iris-grid/src/IrisGrid.tsx 27.36% <18.18%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGridRenderer.ts Outdated
@emilyhuxng emilyhuxng requested a review from dsmmcken February 3, 2023 16:35
@emilyhuxng emilyhuxng merged commit f2efc0a into deephaven:main Feb 3, 2023
@emilyhuxng emilyhuxng deleted the expandable-rows-shows-tooltip branch February 3, 2023 19:59
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expandable rows shows have tooltip

3 participants