Skip to content

feat: Goto Value Improvements#1072

Merged
Zhou-Ziheng merged 10 commits intodeephaven:mainfrom
Zhou-Ziheng:1027-goto-improve
Mar 2, 2023
Merged

feat: Goto Value Improvements#1072
Zhou-Ziheng merged 10 commits intodeephaven:mainfrom
Zhou-Ziheng:1027-goto-improve

Conversation

@Zhou-Ziheng
Copy link
Copy Markdown
Contributor

Fixes #1027

  • null values are not supported by the API, so it is not implemented

@Zhou-Ziheng Zhou-Ziheng self-assigned this Feb 7, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2023

Codecov Report

Merging #1072 (d9c3bff) into main (073f8f5) will increase coverage by 1.37%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
+ Coverage   41.98%   43.36%   +1.37%     
==========================================
  Files         430      434       +4     
  Lines       32342    32675     +333     
  Branches     8125     8238     +113     
==========================================
+ Hits        13578    14168     +590     
+ Misses      18711    18458     -253     
+ Partials       53       49       -4     
Flag Coverage Δ
unit 43.36% <33.33%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/GotoRow.tsx 31.25% <10.52%> (-6.25%) ⬇️
packages/iris-grid/src/IrisGrid.tsx 26.97% <19.23%> (-0.78%) ⬇️
packages/iris-grid/src/IrisGridUtils.ts 53.21% <100.00%> (+1.55%) ⬆️
...shboard-core-plugins/src/panels/MockFileStorage.ts 14.81% <0.00%> (-10.19%) ⬇️
packages/iris-grid/src/IrisGridMetricCalculator.ts 70.58% <0.00%> (-9.42%) ⬇️
packages/grid/src/MockTreeGridModel.ts 89.09% <0.00%> (-5.09%) ⬇️
packages/iris-grid/src/IrisGridProxyModel.ts 67.05% <0.00%> (-1.85%) ⬇️
...ode-studio/src/styleguide/MockIrisGridTreeModel.ts 34.75% <0.00%> (-1.82%) ⬇️
packages/iris-grid/src/IrisGridRenderer.ts 24.36% <0.00%> (-0.49%) ⬇️
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread packages/iris-grid/src/GotoRow.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGridUtils.ts Outdated
Comment thread packages/iris-grid/src/IrisGridUtils.ts Outdated
Comment thread packages/iris-grid/src/IrisGridUtils.ts Outdated
@Zhou-Ziheng Zhou-Ziheng requested a review from mofojed February 10, 2023 20:23
Comment thread packages/iris-grid/src/IrisGridUtils.ts Outdated
Comment thread packages/iris-grid/src/IrisGridUtils.ts Outdated
Comment thread packages/iris-grid/src/IrisGridUtils.test.ts
Comment thread packages/iris-grid/src/GotoRow.tsx
Comment thread packages/iris-grid/src/GotoRow.tsx
Comment thread packages/iris-grid/src/GotoRow.tsx
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx
@Zhou-Ziheng Zhou-Ziheng requested a review from mattrunyon March 1, 2023 21:40
@Zhou-Ziheng Zhou-Ziheng merged commit 970a575 into deephaven:main Mar 2, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go to row improvements

3 participants