feat: Import JS API as a module#1084
Merged
mofojed merged 8 commits intodeephaven:mainfrom Feb 12, 2023
Merged
Conversation
- Doesn't change jsapi-shim at all
Codecov Report
@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 42.10% 42.91% +0.80%
==========================================
Files 432 434 +2
Lines 32555 32593 +38
Branches 8191 8198 +7
==========================================
+ Hits 13707 13987 +280
+ Misses 18795 18557 -238
+ Partials 53 49 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- Shows an error message if it doesn't load properly - Takes a child component that gets shown when loaded - Uses code-splitting to only load the app after the API has successfully loaded
- Can now be used by all the different apps (code-studio, embed-grid, embed-chart) - Could update the error shown to use some of our fancier components (uses modal) - Separate JS API types into their own package - now you can use the types without importing jsapi-shim
- Needed to set up proxies for both
mofojed
changed the title
- Nothing has been changed there yet, not even published
vbabich
previously approved these changes
Feb 10, 2023
vbabich
previously approved these changes
Feb 10, 2023
mattrunyon
previously approved these changes
Feb 10, 2023
- We were building with the full API URL, which was failing to load because of CORS now that we're loading it dynamically - Need to pass the proxy in to the webServer command in playwright, or else it will not load correctly
mattrunyon
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsapi-shiminto a separate pacakgejsapi-typesjsapi-bootstrappackage to load the API and display an error if it can't loadembed-gridandembed-chartpackages. We can now code-split at the top level.Breaking Change: The JS API packaged as a module is now required for the
code-studio,embed-grid, andembed-chartapplications. Existing (Enterprise) applications should be able to usejsapi-shimstill and load the JS API using the old method.