Skip to content

fix: add missing return for editvalueforcell, missing from TS conversion#1090

Merged
dsmmcken merged 1 commit intomainfrom
dmckenzie_1087
Feb 15, 2023
Merged

fix: add missing return for editvalueforcell, missing from TS conversion#1090
dsmmcken merged 1 commit intomainfrom
dmckenzie_1087

Conversation

@dsmmcken
Copy link
Copy Markdown
Contributor

fixes #1087

@dsmmcken dsmmcken requested a review from vbabich February 15, 2023 19:50
@dsmmcken dsmmcken self-assigned this Feb 15, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 15, 2023

Codecov Report

Merging #1090 (5e07f61) into main (28d97ad) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1090   +/-   ##
=======================================
  Coverage   42.91%   42.91%           
=======================================
  Files         434      434           
  Lines       32593    32593           
  Branches     8198     8198           
=======================================
  Hits        13987    13987           
  Misses      18557    18557           
  Partials       49       49           
Flag Coverage Δ
unit 42.91% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/IrisGridProxyModel.ts 67.05% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dsmmcken dsmmcken merged commit 1b00840 into main Feb 15, 2023
@dsmmcken dsmmcken deleted the dmckenzie_1087 branch February 15, 2023 20:12
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Entering edit mode on a cell in an input table should not clear the cell contents

2 participants