feat: isConfirmDangerProp#1110
Merged
bmingles merged 3 commits intodeephaven:mainfrom Feb 27, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
+ Coverage 42.91% 42.93% +0.02%
==========================================
Files 434 434
Lines 32596 32598 +2
Branches 8202 8204 +2
==========================================
+ Hits 13989 13997 +8
+ Misses 18558 18552 -6
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dsmmcken
reviewed
Feb 24, 2023
| const onOpened = useCallback(() => { | ||
| confirmButton.current?.focus(); | ||
| }, []); | ||
| if (isConfirmDanger) { |
Contributor
There was a problem hiding this comment.
I would probably trust the user and keep the focus on the primary action.
test: Added test for prop
vbabich
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1109