fix: Added date time parsing for conditional formatting

[bmingles]

Added datetime string parsing / validation.

fixes #1108

[vbabich]

One suggestion - use camel case and full words for variable names. We try to follow the Airbnb style guide – https://github.com/airbnb/javascript#naming-conventions
with a few exceptions. e as the catch block argument is fine, single-character names in loops and maps are also fine, as long as the loop body is fairly short.

In this case, these are local variables and the scope is short so it's probably fine, but I thought I'd mentioned this anyway.

[codecov]

Codecov Report

Merging #1120 (0b98b7d) into main (4ed5787) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0b98b7d differs from pull request most recent head cc2c1c2. Consider uploading reports for the commit cc2c1c2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   43.37%   43.39%   +0.01%     
==========================================
  Files         434      434              
  Lines       32617    32626       +9     
  Branches     8218     8218              
==========================================
+ Hits        14148    14157       +9     
  Misses      18420    18420              
  Partials       49       49              

Flag	Coverage Δ
unit	43.39% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nditional-formatting/ConditionalFormattingUtils.ts	29.15% <100.00%> (+1.57%)	⬆️
...udio/src/settings/ColumnSpecificSectionContent.tsx	98.73% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dsmmcken]

Would 2023-02-23T11:46:31.000000000 NY FOO pass validation but still fail server size?

[vbabich]

Good catch.
Also, a dateTime string can have a space in place of the t-separator: 2023-02-23 11:46:31.000000000 NY.
Regex for the separator in DateUtils/parseDateTimeString looks like this: [tT\s].

[vbabich]

Ignore my comment, looks like the engine expects a T in format conditions.

[dsmmcken]

It would be nice if we could accepted strings anywhere in the UI that takes a datetime with or without the T separator, then normalize it before sending.

[vbabich]

Agree, also accept datetime with or without the time zone. Should default to the time zone in the user settings. That would be another ticket though.

[bmingles]

@vbabich It was suggested by @niloc132 that instead of using convertDateTime, we could use autoEpochToNanos in the Java expression that gets run by the engine. This would require us to parse the datetime in the UI first and then use the nanos value in the expression. This "should" address the issue we still have with the engine only supporting a subset of timezones.

I'm hesitant to do that for this issue given the current solution is already implemented, but I can create a new issue if we think this is a better solution.

[vbabich]

@bmingles Agreed, open another issue for this.