fix: Add react-dom, redux and react-redux to remote component dependencies#1127
Merged
mofojed merged 1 commit intodeephaven:mainfrom Mar 3, 2023
Merged
fix: Add react-dom, redux and react-redux to remote component dependencies#1127mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## main #1127 +/- ##
=======================================
Coverage 43.38% 43.38%
=======================================
Files 435 435
Lines 32691 32691
Branches 8242 8242
=======================================
Hits 14184 14184
Misses 18458 18458
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
approved these changes
Mar 3, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Great work, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows plugins to connect to the store and to not have to bundle
react-dom