fix: Goto Value Skips Rows on String Column, Displays Incorrect Filter, and shift+enter Doesn't go to Previous#1162
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 44.13% 44.15% +0.01%
==========================================
Files 447 447
Lines 33265 33266 +1
Branches 8356 8355 -1
==========================================
+ Hits 14682 14687 +5
+ Misses 18534 18530 -4
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Add unit tests for checking onSubmit gets called when Enter is pushed on the input
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
For some reason, it looks like submit is getting fired when I'm just clicking "Shift"
Enter should submit and go to next, Shift alone shouldn't do anything, and Shift+Enter should go to previous
Zhou-Ziheng
changed the title
shift+enter Doesn't go to Previous
|
Looks like shift+Enter to go to previous was never implemented, so I added that as well in this PR. |
| }; | ||
|
|
||
| const handleGotoValueKeyDown = (e: KeyboardEvent<HTMLInputElement>) => { | ||
| const handleGotoValueKeySubmit = (e: KeyboardEvent<HTMLInputElement>) => { |
2 participants
fixes #1156, #1157