fix: Double clicking a file causes the loader to flash incorrectly#1189
Merged
mattrunyon merged 5 commits intodeephaven:mainfrom Mar 31, 2023
Merged
fix: Double clicking a file causes the loader to flash incorrectly#1189mattrunyon merged 5 commits intodeephaven:mainfrom
mattrunyon merged 5 commits intodeephaven:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
- Coverage 44.20% 44.20% -0.01%
==========================================
Files 448 448
Lines 33432 33439 +7
Branches 8403 8406 +3
==========================================
+ Hits 14780 14781 +1
- Misses 18602 18608 +6
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattrunyon
added a commit
that referenced
this pull request
Mar 30, 2023
Something I noticed while working on #1189 is that we didn't support double clicking the tab to promote from preview to normal state like VSCode does. This PR lets you double click the tab of a notebook in preview to change it from preview state to normal state. Tested double clicking preview notebook, non-preview notebook, and opening other notebooks in preview after promoting via double click
mofojed
requested changes
Mar 30, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
This isn't right - if I single-click on foo.py, it opens as preview, and then I single-click on bar.py, and it just promotes the existing preview rather than opening bar.py in the preview.
mattrunyon
force-pushed
the
file-open-flash
branch
from
abe6231 to
3b23043
Compare
Collaborator
Author
|
Good catch. Think it's all fixed now |
mofojed
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #942