Skip to content

feat: DH-14630 usePromiseFactory hook#1226

Merged
bmingles merged 3 commits intodeephaven:mainfrom
bmingles:web_DH-14630_use-promise-factory
Apr 17, 2023
Merged

feat: DH-14630 usePromiseFactory hook#1226
bmingles merged 3 commits intodeephaven:mainfrom
bmingles:web_DH-14630_use-promise-factory

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Apr 13, 2023

Enterprise DH-14630
Community #1221

Custom React hook for using Promise factory functions.

@bmingles bmingles linked an issue Apr 13, 2023 that may be closed by this pull request
@bmingles bmingles marked this pull request as ready for review April 13, 2023 20:34
@bmingles bmingles requested review from mattrunyon and mofojed April 13, 2023 20:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2023

Codecov Report

Merging #1226 (c421d50) into main (83f9eef) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
+ Coverage   44.25%   45.02%   +0.76%     
==========================================
  Files         450      454       +4     
  Lines       33487    33559      +72     
  Branches     8423     8447      +24     
==========================================
+ Hits        14820    15109     +289     
+ Misses      18617    18400     -217     
  Partials       50       50              
Flag Coverage Δ
unit 45.02% <100.00%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/react-hooks/src/usePromiseFactory.ts 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread packages/react-hooks/src/usePromiseFactory.ts Outdated
Comment thread packages/react-hooks/src/usePromiseFactory.ts Outdated
Comment thread packages/react-hooks/src/usePromiseFactory.ts Outdated
@bmingles bmingles requested a review from mattrunyon April 14, 2023 14:04
@bmingles bmingles merged commit f8c4ba3 into deephaven:main Apr 17, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2023
@bmingles bmingles deleted the web_DH-14630_use-promise-factory branch April 17, 2023 19:02
@bmingles bmingles changed the title feat: usePromiseFactory hook feat: DH-14630 usePromiseFactory hook Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DH-14630: ACL Editor - usePromiseFactory hook

2 participants