feat: De-globalize JSAPI in Chart package#1258
Merged
vbabich merged 14 commits intodeephaven:mainfrom May 8, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
+ Coverage 45.37% 45.39% +0.02%
==========================================
Files 502 502
Lines 34666 34706 +40
Branches 8675 8677 +2
==========================================
+ Hits 15728 15754 +26
- Misses 18887 18901 +14
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
requested changes
May 2, 2023
| } else if (plotStyle === dh.plot.SeriesPlotStyle.PIE) { | ||
| seriesData.textinfo = 'label+percent'; | ||
|
|
||
| // TODO Open DefinitelyTyped/Plotly PR to mark family and size as optional |
Member
There was a problem hiding this comment.
Looks like we never opened a PR for this...
Collaborator
Author
There was a problem hiding this comment.
I don't have enough information about this, who should have opened a PR?
Member
There was a problem hiding this comment.
It would have been from when Tony was doing TS conversion. If you could create a ticket for it just with this comment and the link to the pie.d.ts, that would be great.
vbabich
commented
May 2, 2023
mofojed
requested changes
May 4, 2023
| "@deephaven/icons": "file:../icons", | ||
| "@deephaven/iris-grid": "file:../iris-grid", | ||
| "@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap", | ||
| "@deephaven/jsapi-shim": "file:../jsapi-shim", |
Member
There was a problem hiding this comment.
Removing this in a future update... looks like the only thing that will need to be updated is the DropdownFilterPanel
vbabich
force-pushed
the
jsapi-deglobalize-chart
branch
from
7012238 to
9d3668f
Compare
mofojed
approved these changes
May 8, 2023
| } else if (plotStyle === dh.plot.SeriesPlotStyle.PIE) { | ||
| seriesData.textinfo = 'label+percent'; | ||
|
|
||
| // TODO Open DefinitelyTyped/Plotly PR to mark family and size as optional |
Member
There was a problem hiding this comment.
It would have been from when Tony was doing TS conversion. If you could create a ticket for it just with this comment and the link to the pie.d.ts, that would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dashboard-core-pluginsto match the Chart package changes.BREAKING CHANGE:
ChartUtilsclass now needs to be instantiated with a JSAPI object, most of the methods converted from static to instance methods.ChartModelFactorymethods require JSAPI object as the first argument.FigureChartModelconstructor requires JSAPI object as the first argument.