fix: DH-14657 Better disconnect handling#1261
Merged
mofojed merged 6 commits intodeephaven:mainfrom May 3, 2023
Merged
Conversation
- This will screw up the fade transition though. Bah
- In some cases, the API disconnects and the reconnects almost immediately afterwards, causing the "Reconnecting..." modal to appear and be distracting - Rather than have the API lie about whether it's connected or not, UI debounces when it displays the modal, just blocking interaction for the duration of the disconnection if the UI just blinks - Also added logging so we can see when connected/disconnected, in case this is further observed
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
=======================================
Coverage 45.57% 45.57%
=======================================
Files 484 486 +2
Lines 34077 34101 +24
Branches 8532 8538 +6
=======================================
+ Hits 15531 15543 +12
- Misses 18495 18507 +12
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mofojed
changed the title
mattrunyon
requested changes
May 3, 2023
Co-authored-by: Matthew Runyon <mattrunyonstuff@gmail.com>
mattrunyon
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debounceMsto5000to be able to react to it